Bug 188830

Summary: The Storage Access API prompt should show the eTLD+1s, not the full host names
Product: WebKit Reporter: John Wilander <wilander>
Component: WebKit Misc.Assignee: John Wilander <wilander>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=188783
Attachments:
Description Flags
Patch none

John Wilander
Reported 2018-08-21 17:08:53 PDT
WebKit::WebPageProxy::requestStorageAccess()'s handling of the StorageAccessStatus::RequiresUserPrompt case should pass on the eTLD+1 for the top and sub frames, not their full host names.
Attachments
Patch (2.49 KB, patch)
2018-08-21 17:12 PDT, John Wilander 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
John Wilander
Comment 1 2018-08-21 17:09:04 PDT
<rdar://problem/43380645>
John Wilander
Comment 2 2018-08-21 17:12:37 PDT
Created attachment 347738 [details] Patch
Brent Fulgham
Comment 3 2018-08-22 15:38:08 PDT
Comment on attachment 347738 [details] Patch r=me.
John Wilander
Comment 4 2018-08-22 15:38:45 PDT
Comment on attachment 347738 [details] Patch Thanks, Brent!
WebKit Commit Bot
Comment 5 2018-08-22 15:54:41 PDT
Comment on attachment 347738 [details] Patch Clearing flags on attachment: 347738 Committed r235209: <https://trac.webkit.org/changeset/235209>
WebKit Commit Bot
Comment 6 2018-08-22 15:54:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.