Bug 188829

Summary:

[Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave

Product:

WebKit

Reporter:

Andy Estes <aestes>

Component:

New Bugs

Assignee:

Andy Estes <aestes>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, andersca, bfulgham, commit-queue, ews-watchlist, joepeck, keith_miller, mark.lam, mcatanzaro, msaboff, pvollan, rniwa, saam, sam, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews201 for win-future	none
Patch	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Patch	none

Andy Estes

Reported 2018-08-21 16:52:07 PDT

[Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave

Attachments
Patch (54.49 KB, patch) 2018-08-21 16:53 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews201 for win-future (12.83 MB, application/zip) 2018-08-22 03:44 PDT, EWS Watchlist	no flags	Details
Patch (57.96 KB, patch) 2018-08-22 14:27 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.12 MB, application/zip) 2018-08-22 16:14 PDT, EWS Watchlist	no flags	Details
Patch (58.44 KB, patch) 2018-08-22 16:34 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Andy Estes

Comment 1 2018-08-21 16:53:09 PDT Comment hidden (obsolete)

Created attachment 347728 [details] Patch

EWS Watchlist

Comment 2 2018-08-21 16:56:31 PDT Comment hidden (obsolete)

Attachment 347728 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: LayoutTests/platform/mac-wk2/TestExpectations:756: Path does not exist. [test/expectations] [5] ERROR: Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebCore/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebKit/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac-wk2/TestExpectations:756: Path does not exist. [test/expectations] [5] Total errors found: 8 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 3 2018-08-22 03:43:59 PDT Comment hidden (obsolete)

Comment on attachment 347728 [details] Patch Attachment 347728 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8942070 New failing tests: http/tests/security/local-video-source-from-remote.html

EWS Watchlist

Comment 4 2018-08-22 03:44:10 PDT Comment hidden (obsolete)

Created attachment 347775 [details] Archive of layout-test-results from ews201 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews201 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Andy Estes

Comment 5 2018-08-22 14:27:00 PDT Comment hidden (obsolete)

Created attachment 347848 [details] Patch

EWS Watchlist

Comment 6 2018-08-22 16:14:05 PDT Comment hidden (obsolete)

Comment on attachment 347848 [details] Patch Attachment 347848 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8949819 New failing tests: http/tests/ssl/applepay/ApplePaySessionV4.html

EWS Watchlist

Comment 7 2018-08-22 16:14:06 PDT Comment hidden (obsolete)

Created attachment 347868 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Andy Estes

Comment 8 2018-08-22 16:34:50 PDT

Created attachment 347873 [details] Patch

WebKit Commit Bot

Comment 9 2018-08-23 15:23:25 PDT

Comment on attachment 347873 [details] Patch Clearing flags on attachment: 347873 Committed r235251: <https://trac.webkit.org/changeset/235251>

WebKit Commit Bot

Comment 10 2018-08-23 15:23:27 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 11 2018-08-23 15:24:22 PDT

<rdar://problem/43661017>

Note You need to log in before you can comment on or make changes to this bug.