Bug 188817

Summary: Cleanup: Add type alias for spell document tag
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebCore Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=188800
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews201 for win-future none

Description Daniel Bates 2018-08-21 14:36:10 PDT
Currently the TextChecking code passes around a int64_t for the spell document tag, a unique identifier that associates the platform-specific spell checking machinery with a particular WebPageProxy. Instead we should define a type alias for this tag.
Comment 1 Daniel Bates 2018-08-21 14:39:18 PDT
Created attachment 347700 [details]
Patch
Comment 2 Simon Fraser (smfr) 2018-08-21 15:24:37 PDT
y u no review
Comment 3 Daniel Bates 2018-08-21 17:33:30 PDT
(In reply to Simon Fraser (smfr) from comment #2)
> y u no review

review away. Didn't want to scare off reviewers with a patch does not apply error since this patch depends on the patch for bug #188800.
Comment 4 EWS Watchlist 2018-08-22 05:27:48 PDT
Comment on attachment 347700 [details]
Patch

Attachment 347700 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8942556

New failing tests:
http/tests/security/canvas-remote-read-remote-video-redirect.html
Comment 5 EWS Watchlist 2018-08-22 05:27:58 PDT
Created attachment 347782 [details]
Archive of layout-test-results from ews201 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 6 Daniel Bates 2018-08-22 09:46:31 PDT
Comment on attachment 347700 [details]
Patch

Clearing flags on attachment: 347700

Committed r235175: <https://trac.webkit.org/changeset/235175>
Comment 7 Daniel Bates 2018-08-22 09:46:32 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-08-22 09:48:24 PDT
<rdar://problem/43608736>