RESOLVED FIXED 188817
Cleanup: Add type alias for spell document tag 
https://bugs.webkit.org/show_bug.cgi?id=188817
Summary Cleanup: Add type alias for spell document tag
Daniel Bates
Reported 2018-08-21 14:36:10 PDT
Currently the TextChecking code passes around a int64_t for the spell document tag, a unique identifier that associates the platform-specific spell checking machinery with a particular WebPageProxy. Instead we should define a type alias for this tag.
Attachments
Patch (27.76 KB, patch)
2018-08-21 14:39 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews201 for win-future (12.79 MB, application/zip)
2018-08-22 05:27 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2018-08-21 14:39:18 PDT
Created attachment 347700 [details] Patch
Simon Fraser (smfr)
Comment 2 2018-08-21 15:24:37 PDT
y u no review
Daniel Bates
Comment 3 2018-08-21 17:33:30 PDT
(In reply to Simon Fraser (smfr) from comment #2) > y u no review review away. Didn't want to scare off reviewers with a patch does not apply error since this patch depends on the patch for bug #188800.
EWS Watchlist
Comment 4 2018-08-22 05:27:48 PDT
Comment on attachment 347700 [details] Patch Attachment 347700 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8942556 New failing tests: http/tests/security/canvas-remote-read-remote-video-redirect.html
EWS Watchlist
Comment 5 2018-08-22 05:27:58 PDT
Created attachment 347782 [details] Archive of layout-test-results from ews201 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews201 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Daniel Bates
Comment 6 2018-08-22 09:46:31 PDT
Comment on attachment 347700 [details] Patch Clearing flags on attachment: 347700 Committed r235175: <https://trac.webkit.org/changeset/235175>
Daniel Bates
Comment 7 2018-08-22 09:46:32 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-08-22 09:48:24 PDT
<rdar://problem/43608736>
Note You need to log in before you can comment on or make changes to this bug.