Bug 188803

Summary: Web Inspector: cannot delete multiple event breakpoints by repeatedly hitting delete
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Matt Baker
Reported 2018-08-21 12:31:50 PDT
The next breakpoint in the tree is selected, but doesn't have the focus, preventing the next delete key press to do nothing. Steps to Reproduce: 1. Debugger tab 2. Add multiple Event Breakpoints 3. Select the last breakpoint item in the list 4. Press the delete key => Breakpoint deleted, previous breakpoint item is selected 5. Hit delete key => Nothing happens, because the tree outline has lost the focus
Attachments
Patch (1.92 KB, patch)
2018-08-21 23:50 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-08-21 12:34:03 PDT
<rdar://problem/43572838>
Devin Rousso
Comment 2 2018-08-21 23:50:21 PDT
Created attachment 347771 [details] Patch
Matt Baker
Comment 3 2018-08-22 10:29:08 PDT
Comment on attachment 347771 [details] Patch We removed and re-appended the tree whenever a breakpoint was deleted! Looks like copypasta from the broken code I added for DOM breakpoints. :(
WebKit Commit Bot
Comment 4 2018-08-22 10:56:50 PDT
Comment on attachment 347771 [details] Patch Clearing flags on attachment: 347771 Committed r235183: <https://trac.webkit.org/changeset/235183>
WebKit Commit Bot
Comment 5 2018-08-22 10:56:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.