Bug 188777

Summary:

Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

DOM

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, cmarcelo, dbates, esprehn+autocc, ews-watchlist, kangil.han, megan_gardner, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

188720

Attachments:

Description	Flags
WIP	none
Cleanup	none
WPE build fix	none
Patch for landing	none

Ryosuke Niwa

Reported 2018-08-20 21:45:20 PDT

Replace booleans for control, alt, meta, etc... keys with OptionSet of modifiers.

Attachments
WIP (39.50 KB, patch) 2018-08-20 21:45 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Cleanup (47.90 KB, patch) 2018-08-21 14:23 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
WPE build fix (47.91 KB, patch) 2018-08-21 15:27 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Patch for landing (47.91 KB, patch) 2018-08-21 19:06 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2018-08-20 21:45:49 PDT

Created attachment 347610 [details] WIP

EWS Watchlist

Comment 2 2018-08-20 21:57:48 PDT

Attachment 347610 [details] did not pass style-queue: ERROR: Source/WebCore/dom/MouseEvent.cpp:83: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseEvent.cpp:83: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/dom/SimulatedClick.cpp:47: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/dom/TouchEvent.cpp:41: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/TouchEvent.cpp:41: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/dom/TouchEvent.cpp:41: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:38: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:38: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:43: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 9 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.

Ryosuke Niwa

Comment 3 2018-08-21 14:23:26 PDT

Created attachment 347694 [details] Cleanup

EWS Watchlist

Comment 4 2018-08-21 14:25:22 PDT

Attachment 347694 [details] did not pass style-queue: ERROR: Source/WebCore/dom/TouchEvent.cpp:41: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/TouchEvent.cpp:41: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseEvent.cpp:83: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseEvent.cpp:83: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/dom/SimulatedClick.cpp:47: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:38: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:38: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:43: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 8 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.

Radar WebKit Bug Importer

Comment 5 2018-08-21 14:28:13 PDT

<rdar://problem/43577361>

Ryosuke Niwa

Comment 6 2018-08-21 15:27:44 PDT

Created attachment 347711 [details] WPE build fix

Simon Fraser (smfr)

Comment 7 2018-08-21 15:31:11 PDT

Comment on attachment 347694 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=347694&action=review > Source/WebCore/ChangeLog:8 > + Replaced boolean arguments and instance variables for modififer keys (ctrl, alt, shift, and meta keys) in modififer > Source/WebCore/platform/PlatformEvent.h:73 > + enum class Modifier : uint8_t { I think this should be called Modifiers (or maybe ModifierKeys?)

Ryosuke Niwa

Comment 8 2018-08-21 15:49:25 PDT

(In reply to Simon Fraser (smfr) from comment #7) > Comment on attachment 347694 [details] > Cleanup > > View in context: > https://bugs.webkit.org/attachment.cgi?id=347694&action=review > > > Source/WebCore/ChangeLog:8 > > + Replaced boolean arguments and instance variables for modififer keys (ctrl, alt, shift, and meta keys) in > > modififer Fixed. > > Source/WebCore/platform/PlatformEvent.h:73 > > + enum class Modifier : uint8_t { > > I think this should be called Modifiers (or maybe ModifierKeys?) I think we ordinarily use singular noun for enum class itself.

EWS Watchlist

Comment 9 2018-08-21 16:16:03 PDT

Attachment 347711 [details] did not pass style-queue: ERROR: Source/WebCore/dom/TouchEvent.cpp:41: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/TouchEvent.cpp:41: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseEvent.cpp:83: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseEvent.cpp:83: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/dom/SimulatedClick.cpp:47: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:38: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:38: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:43: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 8 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.

Ryosuke Niwa

Comment 10 2018-08-21 19:06:50 PDT

Created attachment 347751 [details] Patch for landing

Ryosuke Niwa

Comment 11 2018-08-21 19:07:02 PDT

Comment on attachment 347751 [details] Patch for landing Wait for EWS

EWS Watchlist

Comment 12 2018-08-21 19:08:55 PDT

Attachment 347751 [details] did not pass style-queue: ERROR: Source/WebCore/dom/TouchEvent.cpp:41: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/TouchEvent.cpp:41: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseEvent.cpp:83: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseEvent.cpp:83: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/dom/SimulatedClick.cpp:47: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:38: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:38: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:43: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 8 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.

Ryosuke Niwa

Comment 13 2018-08-21 21:41:07 PDT

Comment on attachment 347751 [details] Patch for landing Clearing flags on attachment: 347751 Committed r235158: <https://trac.webkit.org/changeset/235158>

Ryosuke Niwa

Comment 14 2018-08-21 21:41:09 PDT

All reviewed patches have been landed. Closing bug.

Lucas Forschler

Comment 15 2019-02-06 09:18:30 PST

Mass move bugs into the DOM component.

Note You need to log in before you can comment on or make changes to this bug.