Bug 188771

Summary: Replace WKPageLoaderClient with WKPageNavigationClient in many API tests
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews201 for win-future none

Alex Christensen
Reported 2018-08-20 17:49:37 PDT
Replace WKPageLoaderClient with WKPageNavigationClient in many API tests
Attachments
Patch (71.44 KB, patch)
2018-08-20 17:51 PDT, Alex Christensen 		thorton: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews201 for win-future (12.84 MB, application/zip)
2018-08-21 08:51 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-08-20 17:51:00 PDT
Created attachment 347588 [details] Patch
Tim Horton
Comment 2 2018-08-20 18:01:14 PDT
Comment on attachment 347588 [details] Patch rs=me if the tests pass
EWS Watchlist
Comment 3 2018-08-21 08:51:15 PDT
Comment on attachment 347588 [details] Patch Attachment 347588 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8930464 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html
EWS Watchlist
Comment 4 2018-08-21 08:51:26 PDT
Created attachment 347644 [details] Archive of layout-test-results from ews201 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews201 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Alex Christensen
Comment 5 2018-08-21 09:17:21 PDT
Tests pass and I changed the auto... to parameter names to make GTK happy. http://trac.webkit.org/r235117
Radar WebKit Bug Importer
Comment 6 2018-08-21 09:18:31 PDT
<rdar://problem/43563883>
Note You need to log in before you can comment on or make changes to this bug.