Bug 188765

Summary: Move legacy directory configuration from WebProcessPool to API::WebsiteDataStore
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, berto, cgarcia, commit-queue, ews-watchlist, ggaren, gustavo, mcatanzaro, rniwa, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 188887    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews116 for mac-sierra
none
Archive of layout-test-results from ews206 for win-future
none
Patch
none
Patch none

Sihui Liu
Reported 2018-08-20 16:41:06 PDT
Start to move directory setting from processPool to websiteDataStore.
Attachments
Patch (21.97 KB, patch)
2018-08-20 16:50 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (39.15 KB, patch)
2018-08-21 10:37 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (39.17 KB, patch)
2018-08-21 11:36 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (39.18 KB, patch)
2018-08-21 13:29 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (39.19 KB, patch)
2018-08-21 14:09 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews116 for mac-sierra (3.04 MB, application/zip)
2018-08-21 16:24 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews206 for win-future (12.89 MB, application/zip)
2018-08-21 20:33 PDT, EWS Watchlist 		no flags
Details
Patch (39.41 KB, patch)
2018-08-22 10:07 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (39.79 KB, patch)
2018-08-23 11:45 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2018-08-20 16:50:49 PDT
Created attachment 347570 [details] Patch
Sihui Liu
Comment 2 2018-08-21 10:37:42 PDT
Created attachment 347656 [details] Patch
EWS Watchlist
Comment 3 2018-08-21 10:39:39 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Sihui Liu
Comment 4 2018-08-21 11:36:20 PDT
Created attachment 347663 [details] Patch
Sihui Liu
Comment 5 2018-08-21 13:29:44 PDT
Created attachment 347680 [details] Patch
Sihui Liu
Comment 6 2018-08-21 14:09:50 PDT
Created attachment 347691 [details] Patch
Ryosuke Niwa
Comment 7 2018-08-21 16:22:41 PDT
Comment on attachment 347691 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347691&action=review > Source/WebKit/ChangeLog:7 > + Please explain why we want to do this in the change log.
EWS Watchlist
Comment 8 2018-08-21 16:24:57 PDT
Comment on attachment 347691 [details] Patch Attachment 347691 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/8935679 New failing tests: http/wpt/workers/name-property-enhanced.html
EWS Watchlist
Comment 9 2018-08-21 16:24:59 PDT
Created attachment 347722 [details] Archive of layout-test-results from ews116 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 10 2018-08-21 20:32:57 PDT
Comment on attachment 347691 [details] Patch Attachment 347691 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8939324 New failing tests: http/tests/security/canvas-remote-read-remote-video-redirect.html
EWS Watchlist
Comment 11 2018-08-21 20:33:08 PDT
Created attachment 347759 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Sihui Liu
Comment 12 2018-08-22 10:07:45 PDT
Created attachment 347813 [details] Patch
Sihui Liu
Comment 13 2018-08-22 13:05:25 PDT
(In reply to Ryosuke Niwa from comment #7) > Comment on attachment 347691 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=347691&action=review > > > Source/WebKit/ChangeLog:7 > > + > > Please explain why we want to do this in the change log. Information added!
Geoffrey Garen
Comment 14 2018-08-22 15:50:50 PDT
Comment on attachment 347813 [details] Patch r=me
WebKit Commit Bot
Comment 15 2018-08-22 22:53:04 PDT
Comment on attachment 347813 [details] Patch Clearing flags on attachment: 347813 Committed r235216: <https://trac.webkit.org/changeset/235216>
WebKit Commit Bot
Comment 16 2018-08-22 22:53:06 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 17 2018-08-22 22:54:19 PDT
<rdar://problem/43633183>
WebKit Commit Bot
Comment 18 2018-08-23 08:28:03 PDT
Re-opened since this is blocked by bug 188887
Truitt Savell
Comment 19 2018-08-23 08:33:23 PDT
This patch: https://trac.webkit.org/changeset/235216/webkit Caused 50+ Layout Tests to Crash and 173 api Failures on Debug builds: https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK2%20%28Tests%29/builds/4593 Rollout out in: https://trac.webkit.org/changeset/235224/webkit
Sihui Liu
Comment 20 2018-08-23 11:45:21 PDT
Created attachment 347942 [details] Patch
Geoffrey Garen
Comment 21 2018-08-23 14:09:34 PDT
Comment on attachment 347942 [details] Patch r=me
WebKit Commit Bot
Comment 22 2018-08-23 16:37:52 PDT
Comment on attachment 347942 [details] Patch Clearing flags on attachment: 347942 Committed r235260: <https://trac.webkit.org/changeset/235260>
WebKit Commit Bot
Comment 23 2018-08-23 16:37:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.