Bug 188739

Summary:

Don't place "using namespace XXX;" in global space for unified source builds

Product:

WebKit

Reporter:

Fujii Hironori <Hironori.Fujii>

Component:

New Bugs

Assignee:

Fujii Hironori <Hironori.Fujii>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, keith_miller, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Fujii Hironori

Reported 2018-08-19 22:41:30 PDT

Don't place "using namespace XXX;" in global space for unified source builds (In reply to Yusuke Suzuki from bug #188589 comment #25) > Maybe, I think we should remove `using namespace XXX` as much as possible > since we are now deploying unified builds. But I think this should be done > in a separate patch. (In reply to Darin Adler from bug #188589 comment #28) > Yes, I think we should move this over time. Unified builds makes it a risky > approach, and I think it’s always been risky from a "reduced clarity" point > of view.

Attachments
Patch (10.46 KB, patch) 2018-08-21 02:43 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
Patch (11.40 KB, patch) 2018-08-21 03:10 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
Patch (10.52 KB, patch) 2018-08-21 03:47 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.