Bug 188735

Summary: [Cocoa] Update uses of wrapper template functions in WebKit for clarity, simplicity, better ARC readiness
Product: WebKit Reporter: Darin Adler <darin>
Component: WebKit2Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, mitz, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mitz: review+

Darin Adler
Reported 2018-08-19 16:31:59 PDT
[Cocoa] Update uses of wrapper template functions in WebKit for clarity, simplicity, better ARC readiness
Attachments
Patch (59.21 KB, patch)
2018-08-19 17:01 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (59.21 KB, patch)
2018-08-19 17:30 PDT, Darin Adler 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2018-08-19 17:01:09 PDT
Created attachment 347470 [details] Patch
Darin Adler
Comment 2 2018-08-19 17:30:11 PDT
Created attachment 347473 [details] Patch
mitz
Comment 3 2018-08-19 17:32:18 PDT
Comment on attachment 347473 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347473&action=review > Source/WebKit/ChangeLog:64 > + (-[WKProcessPool _configuration]): Fixed a storage leak by removing leakRef, > + which was not balanaced. This is not a copy or create function, so it should not > + return an object that requires a release to balance it. Yes! I noticed this bug a couple of weeks ago and hadn’t gotten around to writing it up.
Darin Adler
Comment 4 2018-08-19 17:53:39 PDT
Committed r235022: <https://trac.webkit.org/changeset/235022>
Radar WebKit Bug Importer
Comment 5 2018-08-20 16:53:03 PDT
<rdar://problem/43534485>
Note You need to log in before you can comment on or make changes to this bug.