Bug 188720

Summary:

Pass in IsComposed flag to Event constructors

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

DOM

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, darin, ews-watchlist, sam, simon.fraser, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

188692, 188777

Bug Blocks:

170211

Attachments:

Description	Flags
WIP	ews-watchlist: commit-queue-
Archive of layout-test-results from ews203 for win-future	none
WIP2	none
Cleanup	none
Fixed iOS builds	none

Description Ryosuke Niwa 2018-08-18 01:28:23 PDT

Right now, Event::isComposed() implements the check for composed events.
We should be setting them in constructors like CanBubble and IsCancelable.

Comment 1 Ryosuke Niwa 2018-08-18 01:30:30 PDT

Created attachment 347439 [details]
WIP

Comment 2 EWS Watchlist 2018-08-18 01:33:30 PDT

Attachment 347439 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/WheelEvent.cpp:51:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/dom/UIEventWithKeyState.h:45:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/UIEventWithKeyState.h:56:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/UIEventWithKeyState.h:57:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/UIEventWithKeyState.h:58:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/UIEventWithKeyState.h:59:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/UIEventWithKeyState.h:60:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/UIEventWithKeyState.h:61:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/UIEventWithKeyState.h:62:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/MouseRelatedEvent.h:83:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/MouseRelatedEvent.h:83:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/dom/MouseEvent.cpp:90:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/MouseEvent.cpp:90:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/MouseEvent.cpp:90:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/dom/KeyboardEvent.cpp:97:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:43:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:43:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 17 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 EWS Watchlist 2018-08-18 10:54:17 PDT

Comment on attachment 347439 [details]
WIP

Attachment 347439 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8902172

New failing tests:
fast/workers/worker-exception-during-navigation.html
legacy-animation-engine/imported/blink/transitions/unprefixed-transform.html

Comment 4 EWS Watchlist 2018-08-18 10:54:31 PDT

Created attachment 347447 [details]
Archive of layout-test-results from ews203 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews203  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Comment 5 Radar WebKit Bug Importer 2018-08-21 15:23:58 PDT

<rdar://problem/43580387>

Comment 6 Ryosuke Niwa 2018-08-22 23:42:50 PDT

Created attachment 347910 [details]
WIP2

Comment 7 EWS Watchlist 2018-08-22 23:44:44 PDT

Attachment 347910 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/UIEventWithKeyState.h:50:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/UIEventWithKeyState.h:57:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/MouseEvent.cpp:84:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/MouseEvent.cpp:84:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/SimulatedClick.cpp:48:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/dom/KeyboardEvent.cpp:97:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:39:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:39:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 8 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 8 Ryosuke Niwa 2018-08-23 21:12:49 PDT

Created attachment 347986 [details]
Cleanup

Comment 9 EWS Watchlist 2018-08-23 21:16:00 PDT

Attachment 347986 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/UIEventWithKeyState.h:50:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/UIEventWithKeyState.h:57:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/MouseEvent.cpp:84:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/MouseEvent.cpp:84:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/SimulatedClick.cpp:48:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/dom/KeyboardEvent.cpp:97:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:39:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:39:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 8 in 34 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 10 Ryosuke Niwa 2018-08-23 22:23:10 PDT

Created attachment 347990 [details]
Fixed iOS builds

Comment 11 EWS Watchlist 2018-08-23 22:25:27 PDT

Attachment 347990 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/UIEventWithKeyState.h:50:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/UIEventWithKeyState.h:57:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/MouseEvent.cpp:84:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/MouseEvent.cpp:84:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/SimulatedClick.cpp:48:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/dom/KeyboardEvent.cpp:97:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:39:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:39:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 8 in 34 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 12 Ryosuke Niwa 2018-08-24 13:14:52 PDT

Comment on attachment 347990 [details]
Fixed iOS builds

Clearing flags on attachment: 347990

Committed r235331: <https://trac.webkit.org/changeset/235331>

Comment 13 Ryosuke Niwa 2018-08-24 13:14:53 PDT

All reviewed patches have been landed.  Closing bug.

Comment 14 Lucas Forschler 2019-02-06 09:18:56 PST

Mass move bugs into the DOM component.