| Summary: | [CoordGraphics] Switch to Nicosia::CompositionLayer state tracking | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||||||||||||||||||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||
| Severity: | Normal | CC: | bugs-noreply, cgarcia, ews-watchlist, magomez, mcatanzaro, pgriffis, webkit-bug-importer | ||||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=188838 https://bugs.webkit.org/show_bug.cgi?id=188839 https://bugs.webkit.org/show_bug.cgi?id=189224 https://bugs.webkit.org/show_bug.cgi?id=196190 |
||||||||||||||||||||||||||
| Bug Depends on: | |||||||||||||||||||||||||||
| Bug Blocks: | 187385 | ||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||
|
Description
Zan Dobersek
2018-08-17 01:55:39 PDT
Created attachment 347355 [details]
WIP
Attachment 347355 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:113: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4]
ERROR: Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:319: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:1253: Multi line control clauses should use braces. [whitespace/braces] [4]
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 4 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 347355 [details] WIP Attachment 347355 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8902038 New failing tests: imported/blink/transitions/unprefixed-transform.html legacy-animation-engine/imported/blink/transitions/unprefixed-transform.html Created attachment 347444 [details]
Archive of layout-test-results from ews205 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 347483 [details]
WIP
Attachment 347483 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:113: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4]
ERROR: Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:319: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 3 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 347487 [details]
WIP
Attachment 347487 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:113: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4]
ERROR: Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:331: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 3 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 347487 [details] WIP Attachment 347487 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8916565 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html Created attachment 347494 [details]
Archive of layout-test-results from ews200 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 347502 [details]
Patch
Attachment 347502 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:113: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4]
ERROR: Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:331: More than one command on the same line [whitespace/newline] [4]
Total errors found: 2 in 15 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 347502 [details] Patch Attachment 347502 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8918569 New failing tests: http/tests/security/canvas-remote-read-remote-video-localhost.html http/tests/security/video-poster-cross-origin-crash2.html Created attachment 347514 [details]
Archive of layout-test-results from ews202 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Created attachment 347616 [details]
WIP
Attachment 347616 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:113: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4]
ERROR: Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:331: More than one command on the same line [whitespace/newline] [4]
Total errors found: 2 in 15 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 347627 [details]
Patch
Attachment 347627 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:113: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4]
ERROR: Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:331: More than one command on the same line [whitespace/newline] [4]
Total errors found: 2 in 15 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 347627 [details] Patch Attachment 347627 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8933514 New failing tests: http/tests/security/canvas-remote-read-remote-video-localhost.html http/tests/security/video-poster-cross-origin-crash2.html Created attachment 347678 [details]
Archive of layout-test-results from ews202 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Comment on attachment 347627 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347627&action=review I would file bugs for all the FIXMEs to ensure we don't forget about it. > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:453 > + m_nicosia.contentLayer = contentLayer; Should we do this inside the previous if? > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:831 > + } else { > + if (m_nicosia.backingStore) { else if Comment on attachment 347627 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347627&action=review >> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:453 >> + m_nicosia.contentLayer = contentLayer; > > Should we do this inside the previous if? We can. >> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:831 >> + if (m_nicosia.backingStore) { > > else if OK. Created attachment 347779 [details]
Patch for landing
Attachment 347779 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:113: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4]
ERROR: Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:331: More than one command on the same line [whitespace/newline] [4]
Total errors found: 2 in 15 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 347779 [details] Patch for landing Clearing flags on attachment: 347779 Committed r235165: <https://trac.webkit.org/changeset/235165> All reviewed patches have been landed. Closing bug. Hi Zan, this commit caused a *very major* video playback performance regression. It should be obvious playing any video on youtube.com, or http://download.blender.org/peach/bigbuckbunny_movies/big_buck_bunny_720p_stereo.ogg. (In reply to Michael Catanzaro from comment #28) > Hi Zan, this commit caused a *very major* video playback performance > regression. It should be obvious playing any video on youtube.com, or > http://download.blender.org/peach/bigbuckbunny_movies/ > big_buck_bunny_720p_stereo.ogg. This was addressed in bug #189224. |