Bug 188690

Summary:

Modernize results.html

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, basuke, dbates, jbedard, joepeck, ross.kirsling, ryanhaddad, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=188927

Attachments:

Description	Flags
Patch	ap: review+

Simon Fraser (smfr)

Reported 2018-08-16 21:18:18 PDT

Modernize results.html

Attachments
Patch (98.47 KB, patch) 2018-08-16 21:20 PDT, Simon Fraser (smfr)	ap: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2018-08-16 21:20:57 PDT

Created attachment 347348 [details] Patch

Alexey Proskuryakov

Comment 2 2018-08-17 09:27:40 PDT

Comment on attachment 347348 [details] Patch r=me. Please confirm that the page still loads in other browsers - sometimes one's WebKit is so much under development that Safari won't launch to show the page :)

Simon Fraser (smfr)

Comment 3 2018-08-17 11:48:28 PDT

I tested current versions of Chrome and Firefox and both loaded the page fine.

Simon Fraser (smfr)

Comment 4 2018-08-17 11:57:10 PDT

https://trac.webkit.org/r234993

Radar WebKit Bug Importer

Comment 5 2018-08-17 11:58:16 PDT

<rdar://problem/43433940>

Ross Kirsling

Comment 6 2018-08-24 12:36:47 PDT

Ever since this patch, WinCairo layout tests which have a failing text diff and no -expected.png show up as "had no expected results (probably new)": Before: https://build.webkit.org/results/WinCairo%2064-bit%20WKL%20Release%20(Tests)/r234991%20(1085)/results.html After: https://build.webkit.org/results/WinCairo%2064-bit%20WKL%20Release%20(Tests)/r234993%20(1086)/results.html Now, this isn't a huge problem for us, as these test failures are all due to some bot image misconfiguration that we've yet to track down and not reproable locally, and presumably as soon as we fix the bot they'll all disappear anyway, but it is still weird that the dashboard now suggests a lack of expected results when you can clearly see otherwise.

Simon Fraser (smfr)

Comment 7 2018-08-24 12:49:49 PDT

Could you file a new bug for that? Thanks! I did fix some fallout recently.

Ross Kirsling

Comment 8 2018-08-24 12:56:30 PDT

(In reply to Simon Fraser (smfr) from comment #7) > Could you file a new bug for that? Thanks! I did fix some fallout recently. My pleasure! Submitted as bug 188927.

Note You need to log in before you can comment on or make changes to this bug.