Bug 188630 – [LFC][BFC] Display::Box interface should reflect that padding is optional.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[zalan]

ssia

[zalan]

Created attachment 347241 [details]
Patch

[zalan]

Committed r234925: <https://trac.webkit.org/changeset/234925>

[Radar WebKit Bug Importer]

<rdar://problem/43380732>

[Simon Fraser (smfr)]

Comment on attachment 347241 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347241&action=review

> Source/WebCore/ChangeLog:8
> +        Certain type of boxes can't have paddings (see Layout::Box::isPaddingApplicable).

s/paddings/padding/

What's the utility of knowing that there is no padding vs. padding is zero? std::optional<> bloats class layout.

[zalan]

(In reply to Simon Fraser (smfr) from comment #4)
> Comment on attachment 347241 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=347241&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Certain type of boxes can't have paddings (see Layout::Box::isPaddingApplicable).
> 
> s/paddings/padding/
> 
> What's the utility of knowing that there is no padding vs. padding is zero?
> std::optional<> bloats class layout.
From geometry point of view, there's no difference. This is about correctness. If we find std::optional excessive, it's fine to make it debug only and preserve the correctness part of it.