Bug 188621

Summary:

Can't share an app on AppStore to WeChat due to a release assert

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

WebKit2

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, ggaren

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Supresses the release assert	none
Fixed GTK build	none

Description Ryosuke Niwa 2018-08-15 14:28:59 PDT

The assertion we added in https://trac.webkit.org/r233808 is firing for WeChat’s share extension.

We need to add a linked-on-or-after check: ASSERT(RunLoop::isMain() || /* linked before iOS 12 */).

<rdar://problem/43343976>

Comment 1 Ryosuke Niwa 2018-08-15 16:09:55 PDT

Created attachment 347219 [details]
Supresses the release assert

Comment 2 Ryosuke Niwa 2018-08-15 16:10:19 PDT

Comment on attachment 347219 [details]
Supresses the release assert

The patch has already been reviewed by ggaren in person. Just waiting for EWS to land.

Comment 3 Ryosuke Niwa 2018-08-15 16:19:01 PDT

Created attachment 347220 [details]
Fixed GTK build

Comment 4 Ryosuke Niwa 2018-08-15 16:37:33 PDT

Comment on attachment 347220 [details]
Fixed GTK build

Clearing flags on attachment: 347220

Committed r234905: <https://trac.webkit.org/changeset/234905>

Comment 5 Ryosuke Niwa 2018-08-15 16:37:35 PDT

All reviewed patches have been landed.  Closing bug.