Bug 188605

Summary:

Remove unused CSSPrimitiveValue::createAllowingMarginQuirk

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED CONFIGURATION CHANGED

Severity:

Normal

CC:

ahmad.saleem792, ews-watchlist, joepeck, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Patch	joepeck: review+

Alex Christensen

Reported 2018-08-15 09:38:52 PDT

Remove unused CSSPrimitiveValue::createAllowingMarginQuirk

Attachments
Patch (3.14 KB, patch) 2018-08-15 09:39 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (3.66 KB, patch) 2018-08-15 11:53 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.24 MB, application/zip) 2018-08-15 13:13 PDT, EWS Watchlist	no flags	Details
Patch (3.66 KB, patch) 2018-08-16 09:42 PDT, Alex Christensen	joepeck: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2018-08-15 09:39:07 PDT

Created attachment 347169 [details] Patch

Alex Christensen

Comment 2 2018-08-15 11:53:25 PDT

Created attachment 347186 [details] Patch

EWS Watchlist

Comment 3 2018-08-15 13:13:36 PDT

Comment on attachment 347186 [details] Patch Attachment 347186 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8870543 New failing tests: css3/filters/backdrop/add-remove-add-backdrop-filter.html

EWS Watchlist

Comment 4 2018-08-15 13:13:38 PDT

Created attachment 347199 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Alex Christensen

Comment 5 2018-08-16 09:42:01 PDT

Created attachment 347267 [details] Patch

Joseph Pecoraro

Comment 6 2018-08-16 15:10:46 PDT

Comment on attachment 347267 [details] Patch Nice! r=me

Ahmad Saleem

Comment 7 2022-08-13 08:00:44 PDT

This commit: https://github.com/WebKit/WebKit/commit/eb7fc1ad354884881ab821955893b756ff55f14 Addressed both concern, which this patch was trying to resolve: * css/CSSPrimitiveValue.h: Remove unused createAllowingMarginQuirk function and the FIXME-NEWPARSER that said we wouldn't need it any more and the no-longer-needed isQuirkValue function. * css/CSSValue.h: Remove m_isQuirkValue. I am going to mark this as "RESOLVED CONFIGURATION CHANGED". Thanks!

Note You need to log in before you can comment on or make changes to this bug.