Bug 188596

Summary: [Attachment SPI] Remove attachment display mode options
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit2Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, mitz, sam, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Wenson Hsieh
Reported 2018-08-14 20:52:43 PDT
Remove attachment display mode options, since r227068 offers a more suitable alternative for the purposes of Mail.
Attachments
Patch (51.53 KB, patch)
2018-08-14 21:17 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (50.72 KB, patch)
2018-08-14 21:26 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2018-08-14 21:17:49 PDT
Created attachment 347147 [details] Patch
Wenson Hsieh
Comment 2 2018-08-14 21:20:41 PDT
Comment on attachment 347147 [details] Patch Oops, this actually won't work — Mail still sets mode to _WKAttachmentDisplayModeAsIcon.
Wenson Hsieh
Comment 3 2018-08-14 21:26:52 PDT
Created attachment 347148 [details] Patch
WebKit Commit Bot
Comment 4 2018-08-15 07:26:13 PDT
Comment on attachment 347148 [details] Patch Clearing flags on attachment: 347148 Committed r234885: <https://trac.webkit.org/changeset/234885>
WebKit Commit Bot
Comment 5 2018-08-15 07:26:14 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-08-15 07:27:14 PDT
<rdar://problem/43332450>
Note You need to log in before you can comment on or make changes to this bug.