Bug 188596 - [Attachment SPI] Remove attachment display mode options
Summary: [Attachment SPI] Remove attachment display mode options
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-14 20:52 PDT by Wenson Hsieh
Modified: 2018-08-15 07:27 PDT (History)
7 users (show)

See Also:

Attachments
Patch (51.53 KB, patch)
2018-08-14 21:17 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch (50.72 KB, patch)
2018-08-14 21:26 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-08-14 20:52:43 PDT 
Remove attachment display mode options, since r227068 offers a more suitable alternative for the purposes of Mail.
Comment 1 Wenson Hsieh 2018-08-14 21:17:49 PDT 
Created attachment 347147 [details]
Patch
Comment 2 Wenson Hsieh 2018-08-14 21:20:41 PDT 
Comment on attachment 347147 [details]
Patch

Oops, this actually won't work — Mail still sets mode to _WKAttachmentDisplayModeAsIcon.
Comment 3 Wenson Hsieh 2018-08-14 21:26:52 PDT 
Created attachment 347148 [details]
Patch
Comment 4 WebKit Commit Bot 2018-08-15 07:26:13 PDT 
Comment on attachment 347148 [details]
Patch

Clearing flags on attachment: 347148

Committed r234885: <https://trac.webkit.org/changeset/234885>
Comment 5 WebKit Commit Bot 2018-08-15 07:26:14 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-08-15 07:27:14 PDT 
<rdar://problem/43332450>