Bug 188593

Summary:

Web Inspector: Table should not center rows when scrolling them into view

Product:

WebKit

Reporter:

Matt Baker <mattbaker>

Component:

Web Inspector

Assignee:

Matt Baker <mattbaker>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Video] Table scrolling - before	none
[Video] Table scrolling - after	none
Patch	none

Matt Baker

Reported 2018-08-14 17:26:22 PDT

Using up/down arrow keys to scroll the table selection causes the row selection to jump around. Set opt_center false when calling Element.scrollIntoViewIfNeeded.

Attachments
[Video] Table scrolling - before (603.13 KB, video/mp4) 2018-08-14 17:33 PDT, Matt Baker	no flags	Details
[Video] Table scrolling - after (629.53 KB, video/mp4) 2018-08-14 17:33 PDT, Matt Baker	no flags	Details
Patch (1.55 KB, patch) 2018-08-14 17:36 PDT, Matt Baker	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-08-14 17:32:14 PDT

<rdar://problem/43311660>

Matt Baker

Comment 2 2018-08-14 17:33:11 PDT

Created attachment 347136 [details] [Video] Table scrolling - before

Matt Baker

Comment 3 2018-08-14 17:33:34 PDT

Created attachment 347137 [details] [Video] Table scrolling - after

Matt Baker

Comment 4 2018-08-14 17:36:08 PDT

Created attachment 347139 [details] Patch

Devin Rousso

Comment 5 2018-08-14 22:14:49 PDT

Comment on attachment 347139 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347139&action=review r=me > Source/WebInspectorUI/UserInterface/Views/Table.js:1176 > + row.scrollIntoViewIfNeeded(false); Looks like this might be dropped in favor of `Element.scrollIntoView()` at some point in the future. We might have to change it then.

WebKit Commit Bot

Comment 6 2018-08-14 23:10:41 PDT

Comment on attachment 347139 [details] Patch Clearing flags on attachment: 347139 Committed r234882: <https://trac.webkit.org/changeset/234882>

WebKit Commit Bot

Comment 7 2018-08-14 23:10:42 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.