Bug 188565

Summary: [Curl] Implement platform default timeout interval.
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: PlatformAssignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, basuke, commit-queue, darin, ews-watchlist, galpeter, Hironori.Fujii, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=162484
Attachments:
Description Flags
PATCH
none
PATCH
none
PATCH
achristensen: review+, achristensen: commit-queue-
PATCH none

Basuke Suzuki
Reported 2018-08-14 11:13:19 PDT
Curl port didn't implement platform default timeout interval. It treated zero value for timeout interval as no timeout. Caught by this test: * http/tests/xmlhttprequest/on-network-timeout-error-during-preflight.html
Attachments
PATCH (7.85 KB, patch)
2018-08-14 14:11 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
PATCH (7.80 KB, patch)
2018-08-14 14:29 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
PATCH (7.79 KB, patch)
2018-08-14 14:48 PDT, Basuke Suzuki 		achristensen: review+
achristensen: commit-queue-
DetailsFormatted DiffDiff
PATCH (7.79 KB, patch)
2018-08-14 15:36 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2018-08-14 14:11:57 PDT
Created attachment 347108 [details] PATCH
EWS Watchlist
Comment 2 2018-08-14 14:13:17 PDT
Attachment 347108 [details] did not pass style-queue: ERROR: LayoutTests/ChangeLog:9: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:15: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Basuke Suzuki
Comment 3 2018-08-14 14:29:45 PDT
Created attachment 347111 [details] PATCH Fix ChangeLog style
EWS Watchlist
Comment 4 2018-08-14 14:31:31 PDT
Attachment 347111 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:15: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Basuke Suzuki
Comment 5 2018-08-14 14:48:03 PDT
Created attachment 347112 [details] PATCH
Alex Christensen
Comment 6 2018-08-14 15:02:07 PDT
Comment on attachment 347112 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=347112&action=review > Source/WebCore/platform/network/curl/CurlContext.cpp:610 > + // CURLOPT_LOW_SPEED_LIMIT is used instead. It enables the spped watcher speed
Basuke Suzuki
Comment 7 2018-08-14 15:36:17 PDT
Created attachment 347117 [details] PATCH Alex, thanks for r+
WebKit Commit Bot
Comment 8 2018-08-14 16:17:21 PDT
Comment on attachment 347117 [details] PATCH Clearing flags on attachment: 347117 Committed r234864: <https://trac.webkit.org/changeset/234864>
WebKit Commit Bot
Comment 9 2018-08-14 16:17:22 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2018-08-14 16:18:19 PDT
<rdar://problem/43308768>
Note You need to log in before you can comment on or make changes to this bug.