Bug 188560

Summary: [JSC] GetByIdStatus::m_wasSeenInJIT is touched in GetByIdStatus::slowVersion
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: don.olmstead, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch keith_miller: review+

Yusuke Suzuki
Reported 2018-08-14 10:35:41 PDT
[JSC] GetByIdStatus::m_wasSeenInJIT is touched in GetByIdStatus::slowVersion
Attachments
Patch (1.66 KB, patch)
2018-08-14 10:37 PDT, Yusuke Suzuki 		keith_miller: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-08-14 10:37:07 PDT
Created attachment 347089 [details] Patch
Don Olmstead
Comment 2 2018-08-14 10:39:33 PDT
Informal review r+. This was also detected with a UBSan run of ARES6. This one looks like it might've been caught with clang's linter if we ran that as well.
Keith Miller
Comment 3 2018-08-14 10:43:14 PDT
Comment on attachment 347089 [details] Patch Ugh, I wish there was a way we could get a compiler warning about members without default constructors not being initialized...
Yusuke Suzuki
Comment 4 2018-08-14 10:46:08 PDT
(In reply to Keith Miller from comment #3) > Comment on attachment 347089 [details] > Patch > > Ugh, I wish there was a way we could get a compiler warning about members > without default constructors not being initialized... Yeah, this case is a bit complicated. And it is awesome that UBSan catches this. (In reply to Don Olmstead from comment #2) > Informal review r+. This was also detected with a UBSan run of ARES6. > > This one looks like it might've been caught with clang's linter if we ran > that as well. Nice!
Yusuke Suzuki
Comment 5 2018-08-14 10:46:41 PDT
Committed r234855: <https://trac.webkit.org/changeset/234855>
Radar WebKit Bug Importer
Comment 6 2018-08-14 10:47:26 PDT
<rdar://problem/43293111>
Note You need to log in before you can comment on or make changes to this bug.