Bug 188552

Summary: [GStreamer][GL] useless ifdef in pushTextureToCompositor
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, magomez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch calvaris: review+

Philippe Normand
Reported 2018-08-14 06:11:17 PDT
.
Attachments
Patch (3.72 KB, patch)
2018-08-14 06:15 PDT, Philippe Normand 		calvaris: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2018-08-14 06:15:10 PDT
Created attachment 347070 [details] Patch
Xabier Rodríguez Calvar
Comment 2 2018-08-14 22:46:55 PDT
Comment on attachment 347070 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347070&action=review I think it is ok. Anyway, I'd wait until somebody like Miguel has a look at it as well. > Source/WebCore/ChangeLog:10 > + There's no need for a ifdef because the frame holder already Nit: I think it is aN ifdef > Source/WebCore/ChangeLog:11 > + ensures a valid texture ID will set if it maps a GL video frame. will BE set?
Miguel Gomez
Comment 3 2018-08-30 00:56:00 PDT
Looks good to me.
Philippe Normand
Comment 4 2018-08-31 03:23:18 PDT
Committed r235543: <https://trac.webkit.org/changeset/235543>
Radar WebKit Bug Importer
Comment 5 2018-08-31 03:25:25 PDT
<rdar://problem/43933497>
Note You need to log in before you can comment on or make changes to this bug.