Bug 188530

Summary: [MotionMark] Update Leaves test
Product: WebKit Reporter: Jon Lee <jonlee>
Component: AnimationsAssignee: Jon Lee <jonlee>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dino, ews-watchlist, rniwa, sabouhallawa, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jon Lee
Reported 2018-08-13 14:20:44 PDT
Update Leaves test
Attachments
Patch (10.41 KB, patch)
2018-08-13 14:26 PDT, Jon Lee 		no flags
DetailsFormatted DiffDiff
Patch (10.68 KB, patch)
2018-08-13 14:29 PDT, Jon Lee 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-08-13 14:21:23 PDT
<rdar://problem/43251862>
Jon Lee
Comment 2 2018-08-13 14:26:56 PDT
Created attachment 347036 [details] Patch
Jon Lee
Comment 3 2018-08-13 14:29:41 PDT
Created attachment 347037 [details] Patch
Said Abou-Hallawa
Comment 4 2018-08-13 15:50:44 PDT
Comment on attachment 347037 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347037&action=review > PerformanceTests/MotionMark/tests/master/resources/leaves.js:85 > + this.element.style.opacity = this._opacity; The use of this._opacity is be guarded by this.usesOpacity unless this._opacity is always initialized with the default value. But I do not see that.
Jon Lee
Comment 5 2018-08-13 15:56:55 PDT
Comment on attachment 347037 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347037&action=review >> PerformanceTests/MotionMark/tests/master/resources/leaves.js:85 >> + this.element.style.opacity = this._opacity; > > The use of this._opacity is be guarded by this.usesOpacity unless this._opacity is always initialized with the default value. But I do not see that. Good point. It turns out that all of the subclasses do override the method. I'll fix this in the next version.
WebKit Commit Bot
Comment 6 2018-08-13 16:02:14 PDT
Comment on attachment 347037 [details] Patch Clearing flags on attachment: 347037 Committed r234823: <https://trac.webkit.org/changeset/234823>
WebKit Commit Bot
Comment 7 2018-08-13 16:02:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.