Bug 188511

Summary:

WebDriver: include all capabilities in the new session response

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebDriver

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aperez, bburg, bugs-noreply, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	bburg: review+

Description Carlos Garcia Campos 2018-08-13 05:18:22 PDT

As expected by the tests, using the default values when the capability is not provided by the user.

Comment 1 Carlos Garcia Campos 2018-08-13 05:20:23 PDT

Created attachment 347011 [details]
Patch

Comment 2 Adrian Perez 2018-08-13 11:24:21 PDT

Comment on attachment 347011 [details]
Patch

Informal r+, LGTM.

Comment 3 BJ Burg 2018-08-13 14:01:30 PDT

Comment on attachment 347011 [details]
Patch

r=me, although I don't know if emptyString() as a default value may confuse some downstream software like Selenium or Grid.

Comment 4 Carlos Garcia Campos 2018-08-13 23:51:55 PDT

Committed r234837: <https://trac.webkit.org/changeset/234837>

Comment 5 Radar WebKit Bug Importer 2018-08-13 23:53:14 PDT

<rdar://problem/43272816>