Bug 188511 - WebDriver: include all capabilities in the new session response
Summary: WebDriver: include all capabilities in the new session response
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-13 05:18 PDT by Carlos Garcia Campos
Modified: 2018-08-13 23:53 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.67 KB, patch)
2018-08-13 05:20 PDT, Carlos Garcia Campos 		bburg: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2018-08-13 05:18:22 PDT 
As expected by the tests, using the default values when the capability is not provided by the user.
Comment 1 Carlos Garcia Campos 2018-08-13 05:20:23 PDT 
Created attachment 347011 [details]
Patch
Comment 2 Adrian Perez 2018-08-13 11:24:21 PDT 
Comment on attachment 347011 [details]
Patch

Informal r+, LGTM.
Comment 3 BJ Burg 2018-08-13 14:01:30 PDT 
Comment on attachment 347011 [details]
Patch

r=me, although I don't know if emptyString() as a default value may confuse some downstream software like Selenium or Grid.
Comment 4 Carlos Garcia Campos 2018-08-13 23:51:55 PDT 
Committed r234837: <https://trac.webkit.org/changeset/234837>
Comment 5 Radar WebKit Bug Importer 2018-08-13 23:53:14 PDT 
<rdar://problem/43272816>