Bug 188469

Summary: [IntersectionObserver] Implement rootMargin parsing
Product: WebKit Reporter: Ali Juma <ajuma>
Component: Layout and RenderingAssignee: Ali Juma <ajuma>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, darin, esprehn+autocc, ews-watchlist, kondapallykalyan, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 159475    
Attachments:
Description Flags
Patch
none
Follow-up fix none

Ali Juma
Reported 2018-08-10 07:00:57 PDT
Parse the constructor's rootMargin argument and throw an exception if it's invalid.
Attachments
Patch (15.38 KB, patch)
2018-08-10 07:17 PDT, Ali Juma 		no flags
DetailsFormatted DiffDiff
Follow-up fix (1.42 KB, patch)
2018-08-14 10:08 PDT, Ali Juma 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ali Juma
Comment 1 2018-08-10 07:17:16 PDT
Created attachment 346903 [details] Patch
WebKit Commit Bot
Comment 2 2018-08-10 10:08:50 PDT
Comment on attachment 346903 [details] Patch Clearing flags on attachment: 346903 Committed r234761: <https://trac.webkit.org/changeset/234761>
WebKit Commit Bot
Comment 3 2018-08-10 10:08:51 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-08-10 10:09:19 PDT
<rdar://problem/43146118>
Darin Adler
Comment 5 2018-08-14 09:33:25 PDT
Comment on attachment 346903 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346903&action=review > Source/WebCore/page/IntersectionObserver.cpp:114 > + stringBuilder.append("px", 2); Oops, missed this in the initial review. This should instead be: stringBuilder.appendLiteral("px");
Ali Juma
Comment 6 2018-08-14 10:08:50 PDT
Reopening to attach new patch.
Ali Juma
Comment 7 2018-08-14 10:08:52 PDT
Created attachment 347087 [details] Follow-up fix Address review comment
Ali Juma
Comment 8 2018-08-14 10:12:22 PDT
Comment on attachment 347087 [details] Follow-up fix Clearing flags on attachment: 347087 Committed r234851: <https://trac.webkit.org/changeset/234851>
Ali Juma
Comment 9 2018-08-14 10:12:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.