Bug 188454 – [LayoutTests] Test case which committed on r175053 was wrong.

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Basuke Suzuki]

It was originally committed on https://bugs.webkit.org/show_bug.cgi?id=136938 and has kept unchanged, but the test case uses non-existing redirect.php scripts which was removed a few months before than this bug. Also result was compared to wrong values.

[Basuke Suzuki]

Created attachment 346868 [details]
fix

[Basuke Suzuki]

I confirmed the result is same with current Chrome.

[Basuke Suzuki]

Comment on attachment 346868 [details]
fix

View in context: https://bugs.webkit.org/attachment.cgi?id=346868&action=review

> LayoutTests/http/tests/xmlhttprequest/cross-origin-redirect-responseURL-expected.txt:23
> +PASS responseURL is ""

redirect fails so that responseURL should be empty. Also there's no readyState 2,3 happens.

> LayoutTests/http/tests/xmlhttprequest/cross-origin-redirect-responseURL-expected.txt:31
> +PASS responseURL is ""

Ditto.

> LayoutTests/http/tests/xmlhttprequest/cross-origin-redirect-responseURL.html:-37
> -runTest('resources/redirect.php?url=http://127.0.0.1:8000/xmlhttprequest/resources/access-control-basic-allow.cgi', 'text').then(function(req) {

xmlhttprequest/resources/redirect.php was moved to /resources/ with this bug. https://bugs.webkit.org/show_bug.cgi?id=119641

[EWS Watchlist]

Comment on attachment 346868 [details]
fix

Attachment 346868 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/8813588

New failing tests:
fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate.html

[EWS Watchlist]

Created attachment 346879 [details]
Archive of layout-test-results from ews115 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-sierra  Platform: Mac OS X 10.12.6

[WebKit Commit Bot]

Comment on attachment 346868 [details]
fix

Clearing flags on attachment: 346868

Committed r234751: <https://trac.webkit.org/changeset/234751>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/43126703>