Bug 188427

Summary:

Yet more crashes in MobileSafari under -[WKFormInputSession setSuggestions:]

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	wenson_hsieh: review+

Description Tim Horton 2018-08-08 18:40:57 PDT

Yet more crashes in MobileSafari under -[WKFormInputSession setSuggestions:]

Comment 1 Tim Horton 2018-08-08 18:41:19 PDT

Created attachment 346809 [details]
Patch

Comment 2 Tim Horton 2018-08-08 18:41:21 PDT

<rdar://problem/43064672>

Comment 3 Wenson Hsieh 2018-08-08 19:02:24 PDT

Comment on attachment 346809 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346809&action=review

> Source/WebKit/ChangeLog:15
> +        Belt-and-suspenders fix: use ObjCWeakPtr for WKFormInputSession's WKContentView reference.

ObjCWeakPtr => WeakObjCPtr

Comment 4 Tim Horton 2018-08-08 21:36:49 PDT

https://trac.webkit.org/changeset/234719/webkit