Bug 188419

Summary:

Followup (r234683): Element::getAttribute() should return the first non-null attribute value

Product:

WebKit

Reporter:

Said Abou-Hallawa <sabouhallawa>

Component:

SVG

Assignee:

Said Abou-Hallawa <sabouhallawa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, cmarcelo, commit-queue, darin, dbates, esprehn+autocc, ews-watchlist, kangil.han, webkit-bug-importer, zimmermann

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=153854

Attachments:

Description	Flags
Patch	none

Description Said Abou-Hallawa 2018-08-08 14:30:07 PDT

This is a follow up for Darin's comments in https://bugs.webkit.org/show_bug.cgi?id=153854.

In r234683, a new template function Element::getAttribute() was added to return the first non-empty attribute value. The goal was to handle deprecated attributes in a clean way.

Element::getAttribute() should return the first non-null attribute value since an empty string is a legitimate attribute value.

Comment 1 Said Abou-Hallawa 2018-08-08 14:44:55 PDT

Created attachment 346799 [details]
Patch

Comment 2 WebKit Commit Bot 2018-08-13 09:39:22 PDT

Comment on attachment 346799 [details]
Patch

Clearing flags on attachment: 346799

Committed r234803: <https://trac.webkit.org/changeset/234803>

Comment 3 WebKit Commit Bot 2018-08-13 09:39:23 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Radar WebKit Bug Importer 2018-08-13 09:40:29 PDT

<rdar://problem/43236643>