Bug 188418

Summary:

Fix possible null dereference in WebBackForwardList::restoreFromState

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Alex Christensen

Reported 2018-08-08 14:18:28 PDT

Fix possible null dereference in WebBackForwardList::restoreFromState

Attachments
Patch (1.23 KB, patch) 2018-08-08 14:18 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (2.92 KB, patch) 2018-08-08 15:05 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2018-08-08 14:18:51 PDT

Created attachment 346795 [details] Patch

Alex Christensen

Comment 2 2018-08-08 14:18:53 PDT

<rdar://problem/42531726>

Chris Dumez

Comment 3 2018-08-08 14:44:15 PDT

Comment on attachment 346795 [details] Patch I think it is fine to make this change in WebKit. However, let's confirm that it does not crash later on (or that Safari is not visually broken) after this fix before closing <rdar://problem/42531726>, since we have reproduction steps.

Chris Dumez

Comment 4 2018-08-08 14:45:49 PDT

Comment on attachment 346795 [details] Patch Actually, hold on. We should have an API test.

Chris Dumez

Comment 5 2018-08-08 15:03:26 PDT

<rdar://problem/43065730>

Alex Christensen

Comment 6 2018-08-08 15:05:54 PDT

Created attachment 346802 [details] Patch

Chris Dumez

Comment 7 2018-08-08 15:29:23 PDT

Comment on attachment 346802 [details] Patch r=me