Bug 188418

Summary: Fix possible null dereference in WebBackForwardList::restoreFromState
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Alex Christensen 2018-08-08 14:18:28 PDT 
Fix possible null dereference in WebBackForwardList::restoreFromState
Comment 1 Alex Christensen 2018-08-08 14:18:51 PDT 
Created attachment 346795 [details]
Patch
Comment 2 Alex Christensen 2018-08-08 14:18:53 PDT 
<rdar://problem/42531726>
Comment 3 Chris Dumez 2018-08-08 14:44:15 PDT 
Comment on attachment 346795 [details]
Patch

I think it is fine to make this change in WebKit. However, let's confirm that it does not crash later on (or that Safari is not visually broken) after this fix before closing <rdar://problem/42531726>, since we have reproduction steps.
Comment 4 Chris Dumez 2018-08-08 14:45:49 PDT 
Comment on attachment 346795 [details]
Patch

Actually, hold on. We should have an API test.
Comment 5 Chris Dumez 2018-08-08 15:03:26 PDT 
<rdar://problem/43065730>
Comment 6 Alex Christensen 2018-08-08 15:05:54 PDT 
Created attachment 346802 [details]
Patch
Comment 7 Chris Dumez 2018-08-08 15:29:23 PDT 
Comment on attachment 346802 [details]
Patch

r=me
Comment 8 WebKit Commit Bot 2018-08-08 15:58:27 PDT 
Comment on attachment 346802 [details]
Patch

Clearing flags on attachment: 346802

Committed r234714: <https://trac.webkit.org/changeset/234714>
Comment 9 WebKit Commit Bot 2018-08-08 15:58:29 PDT 
All reviewed patches have been landed.  Closing bug.