Summary: | Consolidate data/string API loading paths | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||||||
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | andersca, berto, cgarcia, ews-watchlist, gustavo, mcatanzaro, webkit-bug-importer | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
Alex Christensen
2018-08-08 14:02:15 PDT
Created attachment 346791 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Created attachment 346792 [details]
Patch
Created attachment 346796 [details]
Patch
Created attachment 346797 [details]
Patch
Created attachment 346800 [details]
Patch
Windows failure is unrelated. Created attachment 347187 [details]
Patch
Comment on attachment 347187 [details]
Patch
I reviewed this last week and didn't spot any problems, but didn't r+ because I figured another pair of eyes couldn't hurt. Surprised it didn't receive any.
|