Bug 188417

Summary: Consolidate data/string API loading paths
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, berto, cgarcia, ews-watchlist, gustavo, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch mcatanzaro: review+

Alex Christensen
Reported 2018-08-08 14:02:15 PDT
Consolidate data/string API loading paths
Attachments
Patch (17.47 KB, patch)
2018-08-08 14:05 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (18.61 KB, patch)
2018-08-08 14:14 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (19.53 KB, patch)
2018-08-08 14:26 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (18.98 KB, patch)
2018-08-08 14:32 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (21.27 KB, patch)
2018-08-08 14:52 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (21.30 KB, patch)
2018-08-15 11:55 PDT, Alex Christensen 		mcatanzaro: review+
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-08-08 14:05:14 PDT
Created attachment 346791 [details] Patch
EWS Watchlist
Comment 2 2018-08-08 14:07:30 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Alex Christensen
Comment 3 2018-08-08 14:14:21 PDT
Created attachment 346792 [details] Patch
Alex Christensen
Comment 4 2018-08-08 14:26:46 PDT
Created attachment 346796 [details] Patch
Alex Christensen
Comment 5 2018-08-08 14:32:33 PDT
Created attachment 346797 [details] Patch
Alex Christensen
Comment 6 2018-08-08 14:52:54 PDT
Created attachment 346800 [details] Patch
Alex Christensen
Comment 7 2018-08-09 10:07:13 PDT
Windows failure is unrelated.
Alex Christensen
Comment 8 2018-08-15 11:55:13 PDT
Created attachment 347187 [details] Patch
Michael Catanzaro
Comment 9 2018-08-15 12:57:28 PDT
Comment on attachment 347187 [details] Patch I reviewed this last week and didn't spot any problems, but didn't r+ because I figured another pair of eyes couldn't hurt. Surprised it didn't receive any.
Alex Christensen
Comment 10 2018-08-16 13:52:43 PDT
http://trac.webkit.org/r234954
Radar WebKit Bug Importer
Comment 11 2018-08-16 13:53:32 PDT
<rdar://problem/43394949>
Note You need to log in before you can comment on or make changes to this bug.