Bug 188417 - Consolidate data/string API loading paths
Summary: Consolidate data/string API loading paths
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-08 14:02 PDT by Alex Christensen
Modified: 2018-08-16 13:53 PDT (History)
7 users (show)

See Also:


Attachments
Patch (17.47 KB, patch)
2018-08-08 14:05 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (18.61 KB, patch)
2018-08-08 14:14 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (19.53 KB, patch)
2018-08-08 14:26 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (18.98 KB, patch)
2018-08-08 14:32 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (21.27 KB, patch)
2018-08-08 14:52 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (21.30 KB, patch)
2018-08-15 11:55 PDT, Alex Christensen
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-08-08 14:02:15 PDT
Consolidate data/string API loading paths
Comment 1 Alex Christensen 2018-08-08 14:05:14 PDT
Created attachment 346791 [details]
Patch
Comment 2 EWS Watchlist 2018-08-08 14:07:30 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Alex Christensen 2018-08-08 14:14:21 PDT
Created attachment 346792 [details]
Patch
Comment 4 Alex Christensen 2018-08-08 14:26:46 PDT
Created attachment 346796 [details]
Patch
Comment 5 Alex Christensen 2018-08-08 14:32:33 PDT
Created attachment 346797 [details]
Patch
Comment 6 Alex Christensen 2018-08-08 14:52:54 PDT
Created attachment 346800 [details]
Patch
Comment 7 Alex Christensen 2018-08-09 10:07:13 PDT
Windows failure is unrelated.
Comment 8 Alex Christensen 2018-08-15 11:55:13 PDT
Created attachment 347187 [details]
Patch
Comment 9 Michael Catanzaro 2018-08-15 12:57:28 PDT
Comment on attachment 347187 [details]
Patch

I reviewed this last week and didn't spot any problems, but didn't r+ because I figured another pair of eyes couldn't hurt. Surprised it didn't receive any.
Comment 10 Alex Christensen 2018-08-16 13:52:43 PDT
http://trac.webkit.org/r234954
Comment 11 Radar WebKit Bug Importer 2018-08-16 13:53:32 PDT
<rdar://problem/43394949>