Bug 188411

Summary: Add a WebKit2 logging channel for ActivityState
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: abode0820, commit-queue, ews-watchlist, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
good none

Simon Fraser (smfr)
Reported 2018-08-08 10:47:50 PDT
Add a WebKit2 logging channel for ActivityState
Attachments
Patch (20.38 KB, patch)
2018-08-08 10:49 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
good (197.40 KB, patch)
2018-08-08 11:00 PDT, abdullah 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2018-08-08 10:49:58 PDT
Created attachment 346775 [details] Patch
EWS Watchlist
Comment 2 2018-08-08 10:51:48 PDT
Attachment 346775 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/mac/PageClientImplMac.mm:206: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebKit/UIProcess/mac/PageClientImplMac.mm:218: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 2 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
abdullah
Comment 3 2018-08-08 11:00:29 PDT Comment hidden (obsolete)
WebKit Commit Bot
Comment 4 2018-08-08 12:06:50 PDT
Comment on attachment 346775 [details] Patch Clearing flags on attachment: 346775 Committed r234704: <https://trac.webkit.org/changeset/234704>
WebKit Commit Bot
Comment 5 2018-08-08 12:06:52 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-08-08 12:07:20 PDT
<rdar://problem/43057920>
Note You need to log in before you can comment on or make changes to this bug.