| Summary: | Add a WebKit2 logging channel for ActivityState | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abode0820, commit-queue, ews-watchlist, simon.fraser, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Simon Fraser (smfr)
2018-08-08 10:47:50 PDT
Created attachment 346775 [details]
Patch
Attachment 346775 [details] did not pass style-queue:
ERROR: Source/WebKit/UIProcess/mac/PageClientImplMac.mm:206: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4]
ERROR: Source/WebKit/UIProcess/mac/PageClientImplMac.mm:218: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
Total errors found: 2 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 346777 [details]
good
Comment on attachment 346775 [details] Patch Clearing flags on attachment: 346775 Committed r234704: <https://trac.webkit.org/changeset/234704> All reviewed patches have been landed. Closing bug. |