Bug 188411 - Add a WebKit2 logging channel for ActivityState
Summary: Add a WebKit2 logging channel for ActivityState
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
Keywords: InRadar
Depends on:
Reported: 2018-08-08 10:47 PDT by Simon Fraser (smfr)
Modified: 2018-08-08 12:07 PDT (History)
6 users (show)

See Also:

Patch (20.38 KB, patch)
2018-08-08 10:49 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
good (197.40 KB, patch)
2018-08-08 11:00 PDT, abdullah
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-08-08 10:47:50 PDT
Add a WebKit2 logging channel for ActivityState
Comment 1 Simon Fraser (smfr) 2018-08-08 10:49:58 PDT
Created attachment 346775 [details]
Comment 2 EWS Watchlist 2018-08-08 10:51:48 PDT
Attachment 346775 [details] did not pass style-queue:

ERROR: Source/WebKit/UIProcess/mac/PageClientImplMac.mm:206:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebKit/UIProcess/mac/PageClientImplMac.mm:218:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 2 in 11 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 abdullah 2018-08-08 11:00:29 PDT Comment hidden (obsolete)
Comment 4 WebKit Commit Bot 2018-08-08 12:06:50 PDT
Comment on attachment 346775 [details]

Clearing flags on attachment: 346775

Committed r234704: <https://trac.webkit.org/changeset/234704>
Comment 5 WebKit Commit Bot 2018-08-08 12:06:52 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-08-08 12:07:20 PDT