Bug 188405

Summary: [Nicosia] Add the Nicosia-specific PlatformLayer type alias
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, cmarcelo, commit-queue, dino, don.olmstead, ews-watchlist, graouts, kondapallykalyan, luiz, magomez, noam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 187385    
Attachments:
Description Flags
Patch
none
Patch for landing
none
WinCairo build fix
none
Build fix none

Zan Dobersek
Reported 2018-08-08 00:48:15 PDT
[Nicosia] Add the Nicosia-specific PlatformLayer type alias
Attachments
Patch (34.17 KB, patch)
2018-08-08 01:20 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (34.17 KB, patch)
2018-08-08 02:30 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
WinCairo build fix (1.13 KB, patch)
2018-08-08 11:36 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Build fix (1.13 KB, patch)
2018-08-08 12:27 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2018-08-08 01:20:52 PDT
Created attachment 346759 [details] Patch
EWS Watchlist
Comment 2 2018-08-08 01:22:54 PDT
Attachment 346759 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:857: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Garcia Campos
Comment 3 2018-08-08 01:43:36 PDT
Comment on attachment 346759 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346759&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:777 > + [&](TextureMapperPlatformLayerProxy& proxy) Do we really need to capture everything? I prefer explicit capture and I guess 'this' is the only thing we need to capture here, no?
Zan Dobersek
Comment 4 2018-08-08 02:30:06 PDT
Created attachment 346761 [details] Patch for landing
Zan Dobersek
Comment 5 2018-08-08 02:31:10 PDT
Comment on attachment 346761 [details] Patch for landing Clearing flags on attachment: 346761 Committed r234688: <https://trac.webkit.org/changeset/234688>
Zan Dobersek
Comment 6 2018-08-08 02:31:14 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-08-08 02:32:24 PDT
<rdar://problem/43039520>
Don Olmstead
Comment 8 2018-08-08 11:36:21 PDT
Created attachment 346779 [details] WinCairo build fix An #ifdef guard around USE(NICOSIA) was missing.
Don Olmstead
Comment 9 2018-08-08 12:27:13 PDT
This broke the WinCairo build
Don Olmstead
Comment 10 2018-08-08 12:27:42 PDT
Created attachment 346784 [details] Build fix
WebKit Commit Bot
Comment 11 2018-08-08 13:54:12 PDT
Comment on attachment 346784 [details] Build fix Clearing flags on attachment: 346784 Committed r234710: <https://trac.webkit.org/changeset/234710>
WebKit Commit Bot
Comment 12 2018-08-08 13:54:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.