Bug 188396

Summary:

[ews-build] Separate queues for Builders and Testers - iOS

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, ews-watchlist, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=188516

Attachments:

Description	Flags
Proposed patch	lforschler: review+
Updated patch	none

Aakash Jain

Reported 2018-08-07 17:04:43 PDT

Currently EWS bots build and test on same machine. This is not very efficient. We should instead build (and upload) the archive and re-use it for multiple types of tests (e.g.: WK1, WK2, API tests). This would improve the overall system efficiency by reducing the number of builds while producing same kind of output. This would also improve the overall turn-around time to get EWS results after an engineer uploads a patch. This bug tracks splitting iOS queues in builders and testers.

Attachments
Proposed patch (6.04 KB, patch) 2018-08-07 17:38 PDT, Aakash Jain	lforschler: review+	Details Formatted Diff Diff
Updated patch (6.07 KB, patch) 2018-08-11 20:34 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2018-08-07 17:38:19 PDT

Created attachment 346745 [details] Proposed patch Sample run: iOS-11-Build-EWS: http://ews-build.webkit-uat.org/#/builders/24/builds/12 iOS-11-Simulator-Build-EWS: http://ews-build.webkit-uat.org/#/builders/23/builds/13 iOS-11-Simulator-Tests-EWS: http://ews-build.webkit-uat.org/#/builders/22/builds/11

EWS Watchlist

Comment 2 2018-08-07 17:39:19 PDT Comment hidden (obsolete)

Attachment 346745 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/factories.py:93: [TestsFactory.getProduct] Undefined variable 'DownloadBuiltProduct' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/factories.py:94: [TestsFactory.getProduct] Undefined variable 'ExtractBuiltProduct' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/factories.py:100: [TestsFactory.__init__] self.LayoutTestClass is not callable [pylint/E1102] [5] ERROR: Tools/BuildSlaveSupport/ews-build/factories.py:102: [TestsFactory.__init__] self.APITestClass is not callable [pylint/E1102] [5] ERROR: Tools/BuildSlaveSupport/ews-build/factories.py:119: [APITestsFactory] Undefined variable 'RunAPITests' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/factories.py:131: [iOSTestsFactory] Undefined variable 'RunWebKitTests' [pylint/E0602] [5] Total errors found: 6 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

Lucas Forschler

Comment 3 2018-08-09 17:23:38 PDT

Comment on attachment 346745 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=346745&action=review > Tools/BuildSlaveSupport/ews-build/factories.py:88 > +class TestsFactory(Factory): We use BuildFactory (singular)... maybe we should use TestFactory (singular) here as well? TestsFactory has a weird pronunciation.

Aakash Jain

Comment 4 2018-08-11 20:34:25 PDT

Created attachment 346981 [details] Updated patch > We use BuildFactory (singular)... maybe we should use TestFactory (singular) here as well? Done.

WebKit Commit Bot

Comment 5 2018-08-11 21:14:00 PDT

Comment on attachment 346981 [details] Updated patch Clearing flags on attachment: 346981 Committed r234785: <https://trac.webkit.org/changeset/234785>

WebKit Commit Bot

Comment 6 2018-08-11 21:14:01 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 7 2018-08-11 21:15:03 PDT

<rdar://problem/43193062>

Note You need to log in before you can comment on or make changes to this bug.