Bug 188380

Summary: StorageManager should stop ref'ing IPC::Connections as this is leak-prone
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 188321    
Bug Blocks:    
Attachments:
Description Flags
Patch achristensen: review+

Description Chris Dumez 2018-08-07 10:48:04 PDT
StorageManager should stop ref'ing IPC::Connections as this is leak-prone.
Comment 1 Chris Dumez 2018-08-07 10:49:43 PDT
Created attachment 346715 [details]
Patch
Comment 2 Alex Christensen 2018-08-07 11:48:50 PDT
Comment on attachment 346715 [details]
Patch

This feels like a problem that could also be solved with WeakPtr.  Would that make the Connections too big?
Comment 3 Chris Dumez 2018-08-07 11:53:45 PDT
(In reply to Alex Christensen from comment #2)
> Comment on attachment 346715 [details]
> Patch
> 
> This feels like a problem that could also be solved with WeakPtr.  Would
> that make the Connections too big?

No, but you cannot use WeakPtr as key in a HashMap since its value changes.
Comment 4 Alex Christensen 2018-08-07 12:09:29 PDT
http://trac.webkit.org/r234664
Comment 5 Radar WebKit Bug Importer 2018-08-07 12:10:20 PDT
<rdar://problem/43013954>