Summary: | StorageManager should stop ref'ing IPC::Connections as this is leak-prone | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, commit-queue, rniwa, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 188321 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Chris Dumez
2018-08-07 10:48:04 PDT
Created attachment 346715 [details]
Patch
Comment on attachment 346715 [details]
Patch
This feels like a problem that could also be solved with WeakPtr. Would that make the Connections too big?
(In reply to Alex Christensen from comment #2) > Comment on attachment 346715 [details] > Patch > > This feels like a problem that could also be solved with WeakPtr. Would > that make the Connections too big? No, but you cannot use WeakPtr as key in a HashMap since its value changes. |