Bug 188375

Summary: [WPE][GTK] Handle some virtual keys commonly used on TVs
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WPE WebKitAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, ews-watchlist, zan
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zan: review+

Carlos Garcia Campos
Reported 2018-08-07 01:57:54 PDT
In PlatformKeyboardEvent
Attachments
Patch (18.49 KB, patch)
2018-08-07 02:00 PDT, Carlos Garcia Campos 		zan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2018-08-07 02:00:12 PDT
Created attachment 346697 [details] Patch
EWS Watchlist
Comment 2 2018-08-07 02:02:11 PDT
Attachment 346697 [details] did not pass style-queue: ERROR: Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp:884: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Garcia Campos
Comment 3 2018-08-07 02:41:06 PDT
Committed r234645: <https://trac.webkit.org/changeset/234645>
Note You need to log in before you can comment on or make changes to this bug.