Bug 188375 - [WPE][GTK] Handle some virtual keys commonly used on TVs
Summary: [WPE][GTK] Handle some virtual keys commonly used on TVs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2018-08-07 01:57 PDT by Carlos Garcia Campos
Modified: 2018-08-07 02:41 PDT (History)
3 users (show)

See Also:

Attachments
Patch (18.49 KB, patch)
2018-08-07 02:00 PDT, Carlos Garcia Campos 		zan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2018-08-07 01:57:54 PDT 
In PlatformKeyboardEvent
Comment 1 Carlos Garcia Campos 2018-08-07 02:00:12 PDT 
Created attachment 346697 [details]
Patch
Comment 2 EWS Watchlist 2018-08-07 02:02:11 PDT 
Attachment 346697 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp:884:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Carlos Garcia Campos 2018-08-07 02:41:06 PDT 
Committed r234645: <https://trac.webkit.org/changeset/234645>