Bug 188350

Summary: Use a 1-byte enum class for TextDirection
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2018-08-06 12:53:40 PDT
Use a 1-byte enum class for TextDirection
Attachments
Patch (112.42 KB, patch)
2018-08-06 12:57 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (114.74 KB, patch)
2018-08-06 13:11 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (115.69 KB, patch)
2018-08-06 13:35 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (124.41 KB, patch)
2018-08-06 17:58 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (123.83 KB, patch)
2018-08-06 18:37 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (125.27 KB, patch)
2018-08-07 10:01 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-08-06 12:57:33 PDT
Created attachment 346644 [details] Patch
EWS Watchlist
Comment 2 2018-08-06 13:01:02 PDT
Attachment 346644 [details] did not pass style-queue: ERROR: Source/WebCore/platform/text/WritingMode.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/UserInterfaceLayoutDirection.h:30: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/testing/Internals.h:617: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 3 in 72 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 3 2018-08-06 13:11:59 PDT
Created attachment 346645 [details] Patch
EWS Watchlist
Comment 4 2018-08-06 13:13:40 PDT
Attachment 346645 [details] did not pass style-queue: ERROR: Source/WebCore/platform/text/WritingMode.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/UserInterfaceLayoutDirection.h:30: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/testing/Internals.h:617: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 3 in 73 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 5 2018-08-06 13:35:31 PDT
Created attachment 346650 [details] Patch
EWS Watchlist
Comment 6 2018-08-06 13:39:25 PDT
Attachment 346650 [details] did not pass style-queue: ERROR: Source/WebCore/platform/text/WritingMode.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/UserInterfaceLayoutDirection.h:30: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/testing/Internals.h:617: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 3 in 74 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 7 2018-08-06 17:58:08 PDT
Created attachment 346670 [details] Patch
EWS Watchlist
Comment 8 2018-08-06 18:00:08 PDT
Attachment 346670 [details] did not pass style-queue: ERROR: Source/WebCore/platform/text/WritingMode.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/UserInterfaceLayoutDirection.h:30: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/testing/Internals.h:617: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 3 in 78 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 9 2018-08-06 18:37:50 PDT
Created attachment 346675 [details] Patch
EWS Watchlist
Comment 10 2018-08-06 18:41:10 PDT
Attachment 346675 [details] did not pass style-queue: ERROR: Source/WebCore/platform/text/WritingMode.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/UserInterfaceLayoutDirection.h:30: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/testing/Internals.h:617: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 3 in 77 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 11 2018-08-07 10:01:17 PDT
Created attachment 346710 [details] Patch
EWS Watchlist
Comment 12 2018-08-07 10:04:21 PDT
Attachment 346710 [details] did not pass style-queue: ERROR: Source/WebCore/platform/text/WritingMode.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/UserInterfaceLayoutDirection.h:30: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/testing/Internals.h:617: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 3 in 78 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 13 2018-08-13 11:19:10 PDT
Comment on attachment 346710 [details] Patch Clearing flags on attachment: 346710 Committed r234808: <https://trac.webkit.org/changeset/234808>
WebKit Commit Bot
Comment 14 2018-08-13 11:19:12 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 15 2018-08-13 11:20:31 PDT
<rdar://problem/43242507>
Note You need to log in before you can comment on or make changes to this bug.