Bug 188348

Summary: [Nicosia] Add Nicosia::CompositionLayerTextureMapperImpl
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, magomez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 187385    
Attachments:
Description Flags
Patch
none
Patch for landing none

Zan Dobersek
Reported 2018-08-06 09:15:10 PDT
[Nicosia] Add Nicosia::CompositionLayerTextureMapperImpl
Attachments
Patch (9.66 KB, patch)
2018-08-06 09:24 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (9.71 KB, patch)
2018-08-07 02:07 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2018-08-06 09:24:16 PDT
Created attachment 346632 [details] Patch
Carlos Garcia Campos
Comment 2 2018-08-07 00:13:22 PDT
Comment on attachment 346632 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346632&action=review > Source/WebCore/platform/graphics/nicosia/texmap/NicosiaCompositionLayerTextureMapperImpl.h:46 > + CompositionLayerTextureMapperImpl(); Can we make this private? > Source/WebCore/platform/graphics/nicosia/texmap/NicosiaCompositionLayerTextureMapperImpl.h:53 > + CompositionState& compositionState() { return m_compositionState; } method could be const
Zan Dobersek
Comment 3 2018-08-07 01:43:42 PDT
Comment on attachment 346632 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346632&action=review >> Source/WebCore/platform/graphics/nicosia/texmap/NicosiaCompositionLayerTextureMapperImpl.h:46 >> + CompositionLayerTextureMapperImpl(); > > Can we make this private? No, because of std::make_unique<>(). >> Source/WebCore/platform/graphics/nicosia/texmap/NicosiaCompositionLayerTextureMapperImpl.h:53 >> + CompositionState& compositionState() { return m_compositionState; } > > method could be const Can't be, because the const m_compositionState then can be bound to a non-const reference.
Zan Dobersek
Comment 4 2018-08-07 02:07:59 PDT
Created attachment 346699 [details] Patch for landing
Zan Dobersek
Comment 5 2018-08-07 02:08:51 PDT
Comment on attachment 346699 [details] Patch for landing Clearing flags on attachment: 346699 Committed r234644: <https://trac.webkit.org/changeset/234644>
Zan Dobersek
Comment 6 2018-08-07 02:08:55 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-08-07 02:09:20 PDT
<rdar://problem/42999762>
Note You need to log in before you can comment on or make changes to this bug.