Bug 188340

Summary: [Nicosia] Add Nicosia::Scene
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, magomez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 187385    
Attachments:
Description Flags
Patch none

Zan Dobersek
Reported 2018-08-06 00:15:26 PDT
[Nicosia] Add Nicosia::Scene
Attachments
Patch (13.16 KB, patch)
2018-08-06 00:26 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2018-08-06 00:26:05 PDT
Created attachment 346615 [details] Patch
Carlos Garcia Campos
Comment 2 2018-08-06 00:41:40 PDT
Comment on attachment 346615 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346615&action=review > Source/WebCore/platform/graphics/nicosia/NicosiaScene.cpp:40 > +Scene::Scene() = default; > +Scene::~Scene() = default; > + > +Scene::State::State() = default; > +Scene::State::~State() = default; Do we really need this? Or do you plan to add code to this cpp file in the future?
Zan Dobersek
Comment 3 2018-08-06 01:42:25 PDT
Comment on attachment 346615 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346615&action=review >> Source/WebCore/platform/graphics/nicosia/NicosiaScene.cpp:40 >> +Scene::State::~State() = default; > > Do we really need this? Or do you plan to add code to this cpp file in the future? It might be necessary to add stuff here. If not, I'll come back and simplify things.
Zan Dobersek
Comment 4 2018-08-06 01:46:32 PDT
Comment on attachment 346615 [details] Patch Clearing flags on attachment: 346615 Committed r234593: <https://trac.webkit.org/changeset/234593>
Zan Dobersek
Comment 5 2018-08-06 01:46:36 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-08-06 01:47:18 PDT
<rdar://problem/42961398>
Note You need to log in before you can comment on or make changes to this bug.