Bug 188340

Summary: [Nicosia] Add Nicosia::Scene
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, magomez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 187385    
Attachments:
Description Flags
Patch none

Description Zan Dobersek 2018-08-06 00:15:26 PDT
[Nicosia] Add Nicosia::Scene
Comment 1 Zan Dobersek 2018-08-06 00:26:05 PDT
Created attachment 346615 [details]
Patch
Comment 2 Carlos Garcia Campos 2018-08-06 00:41:40 PDT
Comment on attachment 346615 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346615&action=review

> Source/WebCore/platform/graphics/nicosia/NicosiaScene.cpp:40
> +Scene::Scene() = default;
> +Scene::~Scene() = default;
> +
> +Scene::State::State() = default;
> +Scene::State::~State() = default;

Do we really need this? Or do you plan to add code to this cpp file in the future?
Comment 3 Zan Dobersek 2018-08-06 01:42:25 PDT
Comment on attachment 346615 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346615&action=review

>> Source/WebCore/platform/graphics/nicosia/NicosiaScene.cpp:40
>> +Scene::State::~State() = default;
> 
> Do we really need this? Or do you plan to add code to this cpp file in the future?

It might be necessary to add stuff here. If not, I'll come back and simplify things.
Comment 4 Zan Dobersek 2018-08-06 01:46:32 PDT
Comment on attachment 346615 [details]
Patch

Clearing flags on attachment: 346615

Committed r234593: <https://trac.webkit.org/changeset/234593>
Comment 5 Zan Dobersek 2018-08-06 01:46:36 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-08-06 01:47:18 PDT
<rdar://problem/42961398>