| Summary: | Use enum classes and OptionSets for PaintPhase and PaintBehavior | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, sabouhallawa, simon.fraser, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Alex Christensen
2018-08-03 17:30:40 PDT
Created attachment 346568 [details]
Patch
Created attachment 346573 [details]
Patch
Comment on attachment 346573 [details] Patch Attachment 346573 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/8757691 Number of test failures exceeded the failure limit. Created attachment 346576 [details]
Archive of layout-test-results from ews116 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 346573 [details]
Patch
Make sure it builds!
Created attachment 346637 [details]
Patch
Created attachment 346641 [details]
Patch
Comment on attachment 346641 [details] Patch Rejecting attachment 346641 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 346641, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Simon Frasier found in /Volumes/Data/EWS/WebKit/Source/WTF/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/EWS/WebKit/Source/WTF/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: https://webkit-queues.webkit.org/results/8778620 |