Bug 188323

Summary: Use enum classes and OptionSets for PaintPhase and PaintBehavior
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, sabouhallawa, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews116 for mac-sierra
none
Patch
none
Patch commit-queue: commit-queue-

Alex Christensen
Reported 2018-08-03 17:30:40 PDT
Use enum classes and OptionSets for PaintPhase and PaintBehavior
Attachments
Patch (151.52 KB, patch)
2018-08-03 17:34 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (151.58 KB, patch)
2018-08-03 18:26 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews116 for mac-sierra (1.29 MB, application/zip)
2018-08-03 19:18 PDT, EWS Watchlist 		no flags
Details
Patch (153.52 KB, patch)
2018-08-06 11:33 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (155.41 KB, patch)
2018-08-06 12:34 PDT, Alex Christensen 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-08-03 17:34:04 PDT
Created attachment 346568 [details] Patch
Alex Christensen
Comment 2 2018-08-03 18:26:32 PDT
Created attachment 346573 [details] Patch
EWS Watchlist
Comment 3 2018-08-03 19:18:43 PDT
Comment on attachment 346573 [details] Patch Attachment 346573 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/8757691 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 4 2018-08-03 19:18:44 PDT
Created attachment 346576 [details] Archive of layout-test-results from ews116 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6
Simon Fraser (smfr)
Comment 5 2018-08-03 20:41:32 PDT
Comment on attachment 346573 [details] Patch Make sure it builds!
Alex Christensen
Comment 6 2018-08-06 11:33:06 PDT
Created attachment 346637 [details] Patch
Alex Christensen
Comment 7 2018-08-06 12:34:53 PDT
Created attachment 346641 [details] Patch
WebKit Commit Bot
Comment 8 2018-08-06 12:39:04 PDT
Comment on attachment 346641 [details] Patch Rejecting attachment 346641 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 346641, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Simon Frasier found in /Volumes/Data/EWS/WebKit/Source/WTF/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/EWS/WebKit/Source/WTF/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: https://webkit-queues.webkit.org/results/8778620
Alex Christensen
Comment 9 2018-08-06 13:41:20 PDT
http://trac.webkit.org/r234619
Radar WebKit Bug Importer
Comment 10 2018-08-06 16:38:22 PDT
<rdar://problem/42986547>
Note You need to log in before you can comment on or make changes to this bug.