Bug 188297

Summary:

[LFC] Do not check margin box while validating geometry.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	koivisto: review+

Description zalan 2018-08-02 21:38:59 PDT

the current RenderBox::marginBox is not spec compliant.

Comment 1 zalan 2018-08-02 21:42:16 PDT

Created attachment 346452 [details]
Patch

Comment 2 zalan 2018-08-02 21:43:53 PDT

Comment on attachment 346452 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346452&action=review

> Source/WebCore/layout/Verification.cpp:137
> +#if 0

Not sure what WebKit's policy is about keeping such code around. This will be re-enabled at some point (probably by adding a new function to RenderBox)

Comment 3 zalan 2018-08-03 06:42:43 PDT

Created attachment 346477 [details]
Patch

Comment 4 zalan 2018-08-03 07:21:27 PDT

Committed r234544: <https://trac.webkit.org/changeset/234544>

Comment 5 Radar WebKit Bug Importer 2018-08-03 07:22:20 PDT

<rdar://problem/42898938>