Bug 188260

Summary: Text selection color is hard to see in dark mode web views
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Layout and RenderingAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, megan_gardner, rniwa, simon.fraser, thorton, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Before: blendWithWhite()
none
After: 80% Alpha
none
Patch none

Description Timothy Hatcher 2018-08-02 10:05:57 PDT 
rdar://problem/42721294
Comment 1 Timothy Hatcher 2018-08-02 10:16:41 PDT Comment hidden (obsolete)
Comment 2 Timothy Hatcher 2018-08-02 10:17:08 PDT 
Created attachment 346390 [details]
Before: blendWithWhite()
Comment 3 Timothy Hatcher 2018-08-02 10:17:21 PDT 
Created attachment 346391 [details]
After: 80% Alpha
Comment 4 Simon Fraser (smfr) 2018-08-02 10:56:28 PDT 
Comment on attachment 346389 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346389&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:345
> +        return !color.isOpaque() ? color : color.colorWithAlpha(0.8);

Would be nicer to say where the 0.8 comes from.

> Source/WebCore/rendering/RenderThemeMac.mm:784
> +                return Color(0xCC3F638B, Color::Semantic);

Would prefer to see use the Color(int, int, int) constructor.
Comment 5 Timothy Hatcher 2018-08-02 12:26:55 PDT 
Comment on attachment 346389 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346389&action=review

>> Source/WebCore/rendering/RenderThemeMac.mm:345
>> +        return !color.isOpaque() ? color : color.colorWithAlpha(0.8);
> 
> Would be nicer to say where the 0.8 comes from.

Okay.

>> Source/WebCore/rendering/RenderThemeMac.mm:784
>> +                return Color(0xCC3F638B, Color::Semantic);
> 
> Would prefer to see use the Color(int, int, int) constructor.

Other colors in RenderTheme are hex, so I kept them consistent.
Comment 6 Timothy Hatcher 2018-08-02 12:34:25 PDT 
Created attachment 346406 [details]
Patch
Comment 7 WebKit Commit Bot 2018-08-02 13:12:48 PDT 
Comment on attachment 346406 [details]
Patch

Clearing flags on attachment: 346406

Committed r234512: <https://trac.webkit.org/changeset/234512>
Comment 8 WebKit Commit Bot 2018-08-02 13:12:49 PDT 
All reviewed patches have been landed.  Closing bug.