Bug 188260

Summary: Text selection color is hard to see in dark mode web views
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Layout and RenderingAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, megan_gardner, rniwa, simon.fraser, thorton, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Before: blendWithWhite()
none
After: 80% Alpha
none
Patch none

Timothy Hatcher
Reported 2018-08-02 10:05:57 PDT
rdar://problem/42721294
Attachments
Patch (10.85 KB, patch)
2018-08-02 10:16 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Before: blendWithWhite() (156.32 KB, image/png)
2018-08-02 10:17 PDT, Timothy Hatcher 		no flags
Details
After: 80% Alpha (154.85 KB, image/png)
2018-08-02 10:17 PDT, Timothy Hatcher 		no flags
Details
Patch (11.02 KB, patch)
2018-08-02 12:34 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2018-08-02 10:16:41 PDT Comment hidden (obsolete)
Timothy Hatcher
Comment 2 2018-08-02 10:17:08 PDT
Created attachment 346390 [details] Before: blendWithWhite()
Timothy Hatcher
Comment 3 2018-08-02 10:17:21 PDT
Created attachment 346391 [details] After: 80% Alpha
Simon Fraser (smfr)
Comment 4 2018-08-02 10:56:28 PDT
Comment on attachment 346389 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346389&action=review > Source/WebCore/rendering/RenderThemeMac.mm:345 > + return !color.isOpaque() ? color : color.colorWithAlpha(0.8); Would be nicer to say where the 0.8 comes from. > Source/WebCore/rendering/RenderThemeMac.mm:784 > + return Color(0xCC3F638B, Color::Semantic); Would prefer to see use the Color(int, int, int) constructor.
Timothy Hatcher
Comment 5 2018-08-02 12:26:55 PDT
Comment on attachment 346389 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346389&action=review >> Source/WebCore/rendering/RenderThemeMac.mm:345 >> + return !color.isOpaque() ? color : color.colorWithAlpha(0.8); > > Would be nicer to say where the 0.8 comes from. Okay. >> Source/WebCore/rendering/RenderThemeMac.mm:784 >> + return Color(0xCC3F638B, Color::Semantic); > > Would prefer to see use the Color(int, int, int) constructor. Other colors in RenderTheme are hex, so I kept them consistent.
Timothy Hatcher
Comment 6 2018-08-02 12:34:25 PDT
Created attachment 346406 [details] Patch
WebKit Commit Bot
Comment 7 2018-08-02 13:12:48 PDT
Comment on attachment 346406 [details] Patch Clearing flags on attachment: 346406 Committed r234512: <https://trac.webkit.org/changeset/234512>
WebKit Commit Bot
Comment 8 2018-08-02 13:12:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.