Bug 188255

Summary: [Win][DLLLauncher] Remove --highDPI switch
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: Tools / TestsAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, basuke, bfulgham, commit-queue, don.olmstead, lforschler, pvollan, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Fujii Hironori
Reported 2018-08-02 03:54:36 PDT
[WinCairo] All dump render tree tests are failing in high DPI https://github.com/WebKit/webkit/blob/cb5005335fba0182dad582825751beea625d2cd0/Tools/win/DLLLauncher/DLLLauncherMain.cpp#L173 shouldUseHighDPI should return false for DumpRenderTree.
Attachments
Patch (2.96 KB, patch)
2018-08-06 02:04 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2018-08-02 04:00:09 PDT
I uploaded the result of fast/css/001.htm. https://gist.github.com/fujii/748bdb9e2754152b95ecc0515f265a4b RenderView sizes are different.
Fujii Hironori
Comment 2 2018-08-06 01:24:14 PDT
This code has been added in Bug 149417. But, Bug 158733 has made MiniBrowser always DPI aware. It became useless since the change. Bug 149417 – [Win] Use command-line argument to launch in regular or High DPI mode Bug 158733 – [Win] MiniBrowser is not DPI aware.
Fujii Hironori
Comment 3 2018-08-06 02:04:02 PDT
Created attachment 346618 [details] Patch
Yusuke Suzuki
Comment 4 2018-08-06 03:00:34 PDT
Comment on attachment 346618 [details] Patch r=me
WebKit Commit Bot
Comment 5 2018-08-06 10:43:50 PDT
Comment on attachment 346618 [details] Patch Clearing flags on attachment: 346618 Committed r234607: <https://trac.webkit.org/changeset/234607>
WebKit Commit Bot
Comment 6 2018-08-06 10:43:51 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-08-06 10:44:17 PDT
<rdar://problem/42973487>
Note You need to log in before you can comment on or make changes to this bug.