Bug 188255

Summary: [Win][DLLLauncher] Remove --highDPI switch
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: Tools / TestsAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, Basuke.Suzuki, bfulgham, commit-queue, don.olmstead, lforschler, pvollan, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Fujii Hironori 2018-08-02 03:54:36 PDT 
[WinCairo] All dump render tree tests are failing in high DPI

https://github.com/WebKit/webkit/blob/cb5005335fba0182dad582825751beea625d2cd0/Tools/win/DLLLauncher/DLLLauncherMain.cpp#L173
shouldUseHighDPI should return false for DumpRenderTree.
Comment 1 Fujii Hironori 2018-08-02 04:00:09 PDT 
I uploaded the result of fast/css/001.htm.
https://gist.github.com/fujii/748bdb9e2754152b95ecc0515f265a4b
RenderView sizes are different.
Comment 2 Fujii Hironori 2018-08-06 01:24:14 PDT 
This code has been added in Bug 149417.
But, Bug 158733 has made MiniBrowser always DPI aware. It became useless since the change.

Bug 149417 – [Win] Use command-line argument to launch in regular or High DPI mode
Bug 158733 – [Win] MiniBrowser is not DPI aware.
Comment 3 Fujii Hironori 2018-08-06 02:04:02 PDT 
Created attachment 346618 [details]
Patch
Comment 4 Yusuke Suzuki 2018-08-06 03:00:34 PDT 
Comment on attachment 346618 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2018-08-06 10:43:50 PDT 
Comment on attachment 346618 [details]
Patch

Clearing flags on attachment: 346618

Committed r234607: <https://trac.webkit.org/changeset/234607>
Comment 6 WebKit Commit Bot 2018-08-06 10:43:51 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-08-06 10:44:17 PDT 
<rdar://problem/42973487>