Bug 188232 – [LFC][Floating] Revert back to only one list for the all the floatings.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[alan]

to simplify implementation. if it ends up being a perf bottleneck, we can still split it into left and right floatings.

[alan]

Created attachment 346289 [details]
Patch

[alan]

Created attachment 346293 [details]
Patch

[Antti Koivisto]

Comment on attachment 346293 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346293&action=review

> Source/WebCore/layout/FloatingState.h:64
> +    FloatingList m_floatings;

Is "floatings" a spec term or something? To me "floats" sounds better.

[alan]

(In reply to Antti Koivisto from comment #3)
> Comment on attachment 346293 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=346293&action=review
> 
> > Source/WebCore/layout/FloatingState.h:64
> > +    FloatingList m_floatings;
> 
> Is "floatings" a spec term or something? To me "floats" sounds better.
spec calls floats in many ways:
"The most interesting characteristic of a float (or "floated" or "floating" box).."
I actually prefer "floats" too. AFAIR the only reason why I picked floating was not to confuse it with the primitive type, but I guess it's really hard to confuse them in this context. I'll rename them in a separate patch.

[alan]

Committed r234481: <https://trac.webkit.org/changeset/234481>

[Radar WebKit Bug Importer]

<rdar://problem/42840449>