Bug 188227

Summary: Use iPhone SE as the default simulated device
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, ews-watchlist, glenn, lforschler, ryanhaddad, simon.fraser
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jonathan Bedard
Reported 2018-08-01 10:35:05 PDT
This is long overdue. We need to be using a newer device when running layout tests on simulated devices. This should probably be either the iPhone 8 or iPhone X, but those have a different screen size than the iPhone 5s, so we will need to change some test expectations. In the mean time, let's use the iPhone SE
Attachments
Patch (1.09 KB, patch)
2018-08-01 11:53 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2018-08-01 11:53:45 PDT
Created attachment 346284 [details] Patch
WebKit Commit Bot
Comment 2 2018-08-01 13:29:35 PDT
Comment on attachment 346284 [details] Patch Clearing flags on attachment: 346284 Committed r234467: <https://trac.webkit.org/changeset/234467>
WebKit Commit Bot
Comment 3 2018-08-01 13:29:37 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-08-01 20:26:25 PDT
<rdar://problem/42840280>
Note You need to log in before you can comment on or make changes to this bug.