Bug 188215

Summary: Convert calc-related enums to 8-bit enum classes
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews205 for win-future none

Simon Fraser (smfr)
Reported 2018-07-31 22:33:41 PDT
Convert calc-related enums to 8-bit enum classes
Attachments
Patch (51.54 KB, patch)
2018-07-31 22:34 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews205 for win-future (12.91 MB, application/zip)
2018-08-01 14:35 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2018-07-31 22:34:43 PDT
Created attachment 346261 [details] Patch
EWS Watchlist
Comment 2 2018-07-31 22:37:34 PDT
Attachment 346261 [details] did not pass style-queue: ERROR: Source/WebCore/platform/CalculationValue.h:186: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] ERROR: Source/WebCore/platform/CalculationValue.h:203: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] ERROR: Source/WebCore/platform/CalculationValue.h:218: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] ERROR: Source/WebCore/platform/CalculationValue.h:229: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] Total errors found: 4 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 3 2018-08-01 14:35:30 PDT
Comment on attachment 346261 [details] Patch Attachment 346261 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8726306 New failing tests: http/tests/security/canvas-remote-read-remote-video-localhost.html
EWS Watchlist
Comment 4 2018-08-01 14:35:41 PDT
Created attachment 346300 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
WebKit Commit Bot
Comment 5 2018-08-02 12:19:40 PDT
Comment on attachment 346261 [details] Patch Clearing flags on attachment: 346261 Committed r234506: <https://trac.webkit.org/changeset/234506>
WebKit Commit Bot
Comment 6 2018-08-02 12:19:41 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-08-02 12:21:10 PDT
<rdar://problem/42867817>
Note You need to log in before you can comment on or make changes to this bug.