Bug 188210

Summary: [GStreamer] Make sure that first buffer running time is 0 in GStreamerMediaStreamSource
Product: WebKit Reporter: Thibault Saunier <tsaunier>
Component: New BugsAssignee: Thibault Saunier <tsaunier>
Status: RESOLVED FIXED    
Severity: Normal CC: alex, commit-queue, lforschler, pnormand
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Thibault Saunier
Reported 2018-07-31 16:36:25 PDT
[GStreamer] Make sure that first buffer running time is 0 in GStreamerMediaStreamSource
Attachments
Patch (3.56 KB, patch)
2018-07-31 16:47 PDT, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
Patch (3.56 KB, patch)
2018-08-01 05:41 PDT, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Thibault Saunier
Comment 1 2018-07-31 16:47:13 PDT
Created attachment 346222 [details] Patch
Alejandro G. Castro
Comment 2 2018-07-31 23:51:29 PDT
Comment on attachment 346222 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346222&action=review LGTM, just fix the typo. > Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:512 > + auto pad = adoptGRef(gst_element_get_static_pad(self->videoSrc, "src")); Probably this is a small typo and you wanted to use audioSrc.
Thibault Saunier
Comment 3 2018-08-01 05:41:11 PDT
Created attachment 346273 [details] Patch Fix typo
WebKit Commit Bot
Comment 4 2018-08-01 06:35:45 PDT
Comment on attachment 346273 [details] Patch Clearing flags on attachment: 346273 Committed r234457: <https://trac.webkit.org/changeset/234457>
WebKit Commit Bot
Comment 5 2018-08-01 06:35:46 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-08-01 20:25:14 PDT
<rdar://problem/42840249>
Note You need to log in before you can comment on or make changes to this bug.